Skip to content
Jump to bottom

cmirror next #15

Merged
merged 5 commits into from
Aug 23, 2022
Merged

cmirror next #15

merged 5 commits into from
Aug 23, 2022

Commits on Aug 23, 2022

  1. Add format check macro to printf-style functions

    @donald
    donald committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    7508c9c View commit details
    Browse the repository at this point in the history

  2. Fix printf-format warnings and errors

    @donald
    donald committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    80b0d48 View commit details
    Browse the repository at this point in the history

  3. Fix missing deletion of CLEAN_DIR directories 

    The actual deletion of directories which where added to CLEAN_DIRS by
out_of_the_way() is missing in the code:

buczek@theinternet:~/git/cmirror (fix-printf-formats)$ rm -rf /scratch/local/a
buczek@theinternet:~/git/cmirror (fix-printf-formats)$ rm -rf /scratch/local/b
buczek@theinternet:~/git/cmirror (fix-printf-formats)$ mkdir /scratch/local/a
buczek@theinternet:~/git/cmirror (fix-printf-formats)$ touch /scratch/local/a/test
buczek@theinternet:~/git/cmirror (fix-printf-formats)$ mkdir /scratch/local/b
buczek@theinternet:~/git/cmirror (fix-printf-formats)$ mkdir /scratch/local/b/test
buczek@theinternet:~/git/cmirror (fix-printf-formats)$ cmirror --delete  /scratch/local/a /scratch/local/b
theinternet.molgen.mpg.de: creating empty ./test
theinternet.molgen.mpg.de: rm -r ./test.deleteme
theinternet.molgen.mpg.de: fix directory mtime of . -> 1661234914
buczek@theinternet:~/git/cmirror (fix-printf-formats)$ find /scratch/local/b
/scratch/local/b
/scratch/local/b/test.deleteme
/scratch/local/b/test

Add call to remove directory.
    @donald
    donald committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    b069db6 View commit details
    Browse the repository at this point in the history

  4. Honor --noop for type change of target directory 

    If we are running under --noop and a target directory would be replaced
by another file type, we currently delete the target directory, although
the actual replacement is not installed because of --noop.

Do not remove to-be-replaced directory when --noop is selected.
    @donald
    donald committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    06cf18d View commit details
    Browse the repository at this point in the history

  5. Remove replaced directory even without --delete 

    When a directory is replaced by another type (e.g. a plain file), it is
first renamed and later removed. This later removal should be done
regardless of whether --delete was selected or not.
    @donald
    donald committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    85fdb78 View commit details
    Browse the repository at this point in the history