Next #16
Merged
Next #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Old "next" commits lying around. Dirty installed on deinemuddah because of the "Don't crash if hardlink source is missing' commit, but I want to review/cleanup this before merge. |
Newer versions of glibc set the function attribute `warn_unused_result` on `system()`. We want to ignore a failure in the call with `ionice`, because its best-efford anyway. Unfortunately, the intuitive `(void)system(...)` doesn't work with gcc.
After the last commit, fileop_chown and fileop_lchown are the same. Remove fileop_chown and use fileop_lchown everywhere.
My notebook uses ecryptfs and this surely is a local filesystem.
--ssh-opt is much more powerfull if it can be specified multiple times. So allow that.
We don't free the string vectors `excepts` and `ssh_opts` or the strings they containt, so we can use the strings from argv directly.
I don't remember, what his was for, so remove it.
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
work in progess