cmirror: Allow explicit empty host #18
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, a local copy with a destination containing ":" doesn't work, because `cmirror src /tmp/c:d` would try to use "/tmp/c" as a hostname and `cmirror src :/tmp/c:d` would use ":/tmp/c:d" as a (local) destination. Allow explicit empty hostname, so that the second form can be used to specify a local destination with ":" in the path.
Paul Menzel (pmenzel)
approved these changes
Oct 9, 2023
Sign in
to join this conversation on GitHub.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a local copy with a destination containing ":" doesn't work, because
cmirror src /tmp/c:dwould try to use "/tmp/c" as a hostname andcmirror src :/tmp/c:dwould use ":/tmp/c:d" as a (local) destination.Allow explicit empty hostname, so that the second form can be used to specify a local destination with ":" in the path.