Skip to content

Commit

Permalink
watchdog: sbsa_wdog: Make sure the timeout programming is within the …
Browse files Browse the repository at this point in the history
…limits

Make sure to honour the max_hw_heartbeat_ms while programming the timeout
value to WOR. Clamp the timeout passed to sbsa_gwdt_set_timeout() to
make sure the programmed value is within the permissible range.

Fixes: abd3ac7 ("watchdog: sbsa: Support architecture version 1")

Signed-off-by: George Cherian <george.cherian@marvell.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20230209021117.1512097-1-george.cherian@marvell.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
  • Loading branch information
George Cherian authored and Wim Van Sebroeck committed Feb 18, 2023
1 parent c76675f commit 000987a
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/watchdog/sbsa_gwdt.c
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ static int sbsa_gwdt_set_timeout(struct watchdog_device *wdd,
struct sbsa_gwdt *gwdt = watchdog_get_drvdata(wdd);

wdd->timeout = timeout;
timeout = clamp_t(unsigned int, timeout, 1, wdd->max_hw_heartbeat_ms / 1000);

if (action)
sbsa_gwdt_reg_write(gwdt->clk * timeout, gwdt);
Expand Down

0 comments on commit 000987a

Please sign in to comment.