Skip to content

Commit

Permalink
genirq: generic chip: Use DIV_ROUND_UP to calculate numchips
Browse files Browse the repository at this point in the history
The number of interrupts in a domain may be not divisible by the
number of interrupts each chip handles. Integer division may truncate
the result, thus use DIV_ROUND_UP to count numchips.

Seems all users of irq_alloc_domain_generic_chips() in current code do
not have this issue. I just found the issue while reading the code.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Cc: Grant Likely <grant.likely@linaro.org>
Cc: Tony Lindgren <tony@atomide.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Link: http://lkml.kernel.org/r/1373015592.18252.2.camel@phoenix
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
  • Loading branch information
Axel Lin authored and Thomas Gleixner committed Jul 5, 2013
1 parent 5b8aae4 commit 002fca5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion kernel/irq/generic-chip.c
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ int irq_alloc_domain_generic_chips(struct irq_domain *d, int irqs_per_chip,
if (d->revmap_type != IRQ_DOMAIN_MAP_LINEAR)
return -EINVAL;

numchips = d->revmap_data.linear.size / irqs_per_chip;
numchips = DIV_ROUND_UP(d->revmap_data.linear.size, irqs_per_chip);
if (!numchips)
return -EINVAL;

Expand Down

0 comments on commit 002fca5

Please sign in to comment.