Skip to content

Commit

Permalink
GFS2: Merge gfs2_get_sb into gfs2_get_sb_meta
Browse files Browse the repository at this point in the history
These don't need to be separate functions.

Reported-by: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
  • Loading branch information
Steven Whitehouse committed Jun 10, 2009
1 parent 40bc9a2 commit 003dec8
Showing 1 changed file with 4 additions and 12 deletions.
16 changes: 4 additions & 12 deletions fs/gfs2/ops_fstype.c
Original file line number Diff line number Diff line change
Expand Up @@ -1284,31 +1284,23 @@ static int set_meta_super(struct super_block *s, void *ptr)
return -EINVAL;
}

static struct super_block *get_gfs2_sb(const char *dev_name)
static int gfs2_get_sb_meta(struct file_system_type *fs_type, int flags,
const char *dev_name, void *data, struct vfsmount *mnt)
{
struct super_block *s;
struct gfs2_sbd *sdp;
struct path path;
int error;

error = kern_path(dev_name, LOOKUP_FOLLOW, &path);
if (error) {
printk(KERN_WARNING "GFS2: path_lookup on %s returned error %d\n",
dev_name, error);
return ERR_PTR(-ENOENT);
return error;
}
s = sget(&gfs2_fs_type, test_meta_super, set_meta_super,
path.dentry->d_inode->i_sb->s_bdev);
path_put(&path);
return s;
}

static int gfs2_get_sb_meta(struct file_system_type *fs_type, int flags,
const char *dev_name, void *data, struct vfsmount *mnt)
{
struct super_block *s;
struct gfs2_sbd *sdp;

s = get_gfs2_sb(dev_name);
if (IS_ERR(s)) {
printk(KERN_WARNING "GFS2: gfs2 mount does not exist\n");
return PTR_ERR(s);
Expand Down

0 comments on commit 003dec8

Please sign in to comment.