Skip to content

Commit

Permalink
net: dsa: remove calls to genphy_config_init
Browse files Browse the repository at this point in the history
Supported PHY features are either auto-detected or explicitly set.
In both cases calling genphy_config_init isn't needed.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Heiner Kallweit authored and David S. Miller committed Aug 17, 2019
1 parent c227ce4 commit 00843d9
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions net/dsa/port.c
Original file line number Diff line number Diff line change
Expand Up @@ -538,10 +538,6 @@ static int dsa_port_setup_phy_of(struct dsa_port *dp, bool enable)
return PTR_ERR(phydev);

if (enable) {
err = genphy_config_init(phydev);
if (err < 0)
goto err_put_dev;

err = genphy_resume(phydev);
if (err < 0)
goto err_put_dev;
Expand Down Expand Up @@ -589,7 +585,6 @@ static int dsa_port_fixed_link_register_of(struct dsa_port *dp)
mode = PHY_INTERFACE_MODE_NA;
phydev->interface = mode;

genphy_config_init(phydev);
genphy_read_status(phydev);

if (ds->ops->adjust_link)
Expand Down

0 comments on commit 00843d9

Please sign in to comment.