Skip to content

Commit

Permalink
HID: prodikeys: kfree() NULL pointer cleanup
Browse files Browse the repository at this point in the history
No need for freeing pm in case when it's not allocated.

Reported-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Bojan Prtvar <prtvar.b@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
  • Loading branch information
Bojan Prtvar authored and Jiri Kosina committed Aug 4, 2011
1 parent 6371fe5 commit 00b1562
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/hid/hid-prodikeys.c
Original file line number Diff line number Diff line change
Expand Up @@ -816,7 +816,7 @@ static int pk_probe(struct hid_device *hdev, const struct hid_device_id *id)
if (pm == NULL) {
hid_err(hdev, "can't alloc descriptor\n");
ret = -ENOMEM;
goto err_free;
goto err_free_pk;
}

pm->pk = pk;
Expand Down Expand Up @@ -849,10 +849,10 @@ static int pk_probe(struct hid_device *hdev, const struct hid_device_id *id)
err_stop:
hid_hw_stop(hdev);
err_free:
if (pm != NULL)
kfree(pm);

kfree(pm);
err_free_pk:
kfree(pk);

return ret;
}

Expand Down

0 comments on commit 00b1562

Please sign in to comment.