Skip to content

Commit

Permalink
dt-bindings: qcom-qce: Add new SoC compatible strings for Qualcomm QC…
Browse files Browse the repository at this point in the history
…E IP

Introduce a generic IP family compatible 'qcom,qce' and its two derivatives
based on SoC names rather than on IP versions. Having a generic compatible
is only partially sufficient, the QCE IP version can be discovered in
runtime, however there are two known groups of QCE IP versions, which
require different DT properties, these two groups are populated with SoC
based compatibles known at the moment.

Keep the old compatible 'qcom,crypto-v5.1' and document an existing and
already used but not previously documented compatible 'qcom,crypto-v5.4'
for backward compatibility of DTB ABI, mark both of the compatibles as
deprecated.

The change is based on the original one written by Bhupesh Sharma, adding
a generic family compatible is suggested by Neil Armstrong.

Cc: Bhupesh Sharma <bhupesh.sharma@linaro.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
  • Loading branch information
Vladimir Zapolskiy authored and Herbert Xu committed Mar 14, 2023
1 parent c168dc4 commit 00f3bc2
Showing 1 changed file with 27 additions and 2 deletions.
29 changes: 27 additions & 2 deletions Documentation/devicetree/bindings/crypto/qcom-qce.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,32 @@ description:

properties:
compatible:
const: qcom,crypto-v5.1
oneOf:
- const: qcom,crypto-v5.1
deprecated: true
description: Kept only for ABI backward compatibility

- const: qcom,crypto-v5.4
deprecated: true
description: Kept only for ABI backward compatibility

- items:
- enum:
- qcom,ipq6018-qce
- qcom,ipq8074-qce
- qcom,msm8996-qce
- qcom,sdm845-qce
- const: qcom,ipq4019-qce
- const: qcom,qce

- items:
- enum:
- qcom,sm8250-qce
- qcom,sm8350-qce
- qcom,sm8450-qce
- qcom,sm8550-qce
- const: qcom,sm8150-qce
- const: qcom,qce

reg:
maxItems: 1
Expand Down Expand Up @@ -70,7 +95,7 @@ examples:
- |
#include <dt-bindings/clock/qcom,gcc-apq8084.h>
crypto-engine@fd45a000 {
compatible = "qcom,crypto-v5.1";
compatible = "qcom,ipq6018-qce", "qcom,ipq4019-qce", "qcom,qce";
reg = <0xfd45a000 0x6000>;
clocks = <&gcc GCC_CE2_AHB_CLK>,
<&gcc GCC_CE2_AXI_CLK>,
Expand Down

0 comments on commit 00f3bc2

Please sign in to comment.