Skip to content

Commit

Permalink
ieee1394: remove superfluous assertions
Browse files Browse the repository at this point in the history
hpsb_read, hpsb_write, hpsb_lock are sleeping functions which nobody is
in danger to use in atomic context.  Besides, in_interrupt does not
cover all types of atomic context.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
  • Loading branch information
Stefan Richter committed Feb 24, 2009
1 parent 9c939e4 commit 00fc307
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions drivers/ieee1394/ieee1394_transactions.c
Original file line number Diff line number Diff line change
Expand Up @@ -501,8 +501,6 @@ int hpsb_read(struct hpsb_host *host, nodeid_t node, unsigned int generation,
if (length == 0)
return -EINVAL;

BUG_ON(in_interrupt()); // We can't be called in an interrupt, yet

packet = hpsb_make_readpacket(host, node, addr, length);

if (!packet) {
Expand Down Expand Up @@ -550,8 +548,6 @@ int hpsb_write(struct hpsb_host *host, nodeid_t node, unsigned int generation,
if (length == 0)
return -EINVAL;

BUG_ON(in_interrupt()); // We can't be called in an interrupt, yet

packet = hpsb_make_writepacket(host, node, addr, buffer, length);

if (!packet)
Expand All @@ -577,8 +573,6 @@ int hpsb_lock(struct hpsb_host *host, nodeid_t node, unsigned int generation,
struct hpsb_packet *packet;
int retval = 0;

BUG_ON(in_interrupt());

packet = hpsb_make_lockpacket(host, node, addr, extcode, data, arg);
if (!packet)
return -ENOMEM;
Expand Down

0 comments on commit 00fc307

Please sign in to comment.