Skip to content

Commit

Permalink
[CPUFREQ] check sysfs_create_link return value
Browse files Browse the repository at this point in the history
Trivial patch to check sysfs_create_link return values.
Fail gracefully if needed.

Signed-off-by: Ahmed Darwish <darwish.07@gmail.com>
Signed-off-by: Dave Jones <davej@redhat.com>
  • Loading branch information
Ahmed S. Darwish authored and Dave Jones committed Jan 29, 2007
1 parent 5263bf6 commit 0142f9d
Showing 1 changed file with 13 additions and 4 deletions.
17 changes: 13 additions & 4 deletions drivers/cpufreq/cpufreq.c
Original file line number Diff line number Diff line change
Expand Up @@ -722,8 +722,13 @@ static int cpufreq_add_dev (struct sys_device * sys_dev)
spin_unlock_irqrestore(&cpufreq_driver_lock, flags);

dprintk("CPU already managed, adding link\n");
sysfs_create_link(&sys_dev->kobj,
&managed_policy->kobj, "cpufreq");
ret = sysfs_create_link(&sys_dev->kobj,
&managed_policy->kobj,
"cpufreq");
if (ret) {
mutex_unlock(&policy->lock);
goto err_out_driver_exit;
}

cpufreq_debug_enable_ratelimit();
mutex_unlock(&policy->lock);
Expand Down Expand Up @@ -770,8 +775,12 @@ static int cpufreq_add_dev (struct sys_device * sys_dev)
dprintk("CPU %u already managed, adding link\n", j);
cpufreq_cpu_get(cpu);
cpu_sys_dev = get_cpu_sysdev(j);
sysfs_create_link(&cpu_sys_dev->kobj, &policy->kobj,
"cpufreq");
ret = sysfs_create_link(&cpu_sys_dev->kobj, &policy->kobj,
"cpufreq");
if (ret) {
mutex_unlock(&policy->lock);
goto err_out_unregister;
}
}

policy->governor = NULL; /* to assure that the starting sequence is
Expand Down

0 comments on commit 0142f9d

Please sign in to comment.