Skip to content

Commit

Permalink
net: dsa: bcm_sf2: store PHY interface/mode in port structure
Browse files Browse the repository at this point in the history
It's needed later for proper switch / crossbar setup.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Rafał Miłecki authored and David S. Miller committed Mar 13, 2021
1 parent 6ad0860 commit 01488a0
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 4 deletions.
16 changes: 12 additions & 4 deletions drivers/net/dsa/bcm_sf2.c
Original file line number Diff line number Diff line change
Expand Up @@ -443,10 +443,11 @@ static void bcm_sf2_intr_disable(struct bcm_sf2_priv *priv)
static void bcm_sf2_identify_ports(struct bcm_sf2_priv *priv,
struct device_node *dn)
{
struct device *dev = priv->dev->ds->dev;
struct bcm_sf2_port_status *port_st;
struct device_node *port;
unsigned int port_num;
struct property *prop;
phy_interface_t mode;
int err;

priv->moca_port = -1;
Expand All @@ -455,19 +456,26 @@ static void bcm_sf2_identify_ports(struct bcm_sf2_priv *priv,
if (of_property_read_u32(port, "reg", &port_num))
continue;

if (port_num >= DSA_MAX_PORTS) {
dev_err(dev, "Invalid port number %d\n", port_num);
continue;
}

port_st = &priv->port_sts[port_num];

/* Internal PHYs get assigned a specific 'phy-mode' property
* value: "internal" to help flag them before MDIO probing
* has completed, since they might be turned off at that
* time
*/
err = of_get_phy_mode(port, &mode);
err = of_get_phy_mode(port, &port_st->mode);
if (err)
continue;

if (mode == PHY_INTERFACE_MODE_INTERNAL)
if (port_st->mode == PHY_INTERFACE_MODE_INTERNAL)
priv->int_phy_mask |= 1 << port_num;

if (mode == PHY_INTERFACE_MODE_MOCA)
if (port_st->mode == PHY_INTERFACE_MODE_MOCA)
priv->moca_port = port_num;

if (of_property_read_bool(port, "brcm,use-bcm-hdr"))
Expand Down
1 change: 1 addition & 0 deletions drivers/net/dsa/bcm_sf2.h
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ struct bcm_sf2_hw_params {
#define BCM_SF2_REGS_NUM 6

struct bcm_sf2_port_status {
phy_interface_t mode;
unsigned int link;
bool enabled;
};
Expand Down

0 comments on commit 01488a0

Please sign in to comment.