Skip to content

Commit

Permalink
net: ethoc: Make use of the helper function dev_err_probe()
Browse files Browse the repository at this point in the history
When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
And using dev_err_probe() can reduce code size, and simplify the code.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Cai Huoqing authored and David S. Miller committed Sep 16, 2021
1 parent a72691e commit 015a22f
Showing 1 changed file with 4 additions and 8 deletions.
12 changes: 4 additions & 8 deletions drivers/net/ethernet/ethoc.c
Original file line number Diff line number Diff line change
Expand Up @@ -707,20 +707,16 @@ static int ethoc_mdio_probe(struct net_device *dev)
else
phy = phy_find_first(priv->mdio);

if (!phy) {
dev_err(&dev->dev, "no PHY found\n");
return -ENXIO;
}
if (!phy)
return dev_err_probe(&dev->dev, -ENXIO, "no PHY found\n");

priv->old_duplex = -1;
priv->old_link = -1;

err = phy_connect_direct(dev, phy, ethoc_mdio_poll,
PHY_INTERFACE_MODE_GMII);
if (err) {
dev_err(&dev->dev, "could not attach to PHY\n");
return err;
}
if (err)
return dev_err_probe(&dev->dev, err, "could not attach to PHY\n");

phy_set_max_speed(phy, SPEED_100);

Expand Down

0 comments on commit 015a22f

Please sign in to comment.