Skip to content

Commit

Permalink
usb: dwc2: Remove unnecessary request length checking
Browse files Browse the repository at this point in the history
Remove request length checking from dwc2_hsotg_unmap_dma() and
dwc2_hsotg_map_dma(). That checking is done in functions called from
those functions, usb_gadget_unmap_request_by_dev() and
usb_gadget_map_request_by_dev() respectively, so it's unnecessary.

Signed-off-by: Razmik Karapetyan <razmik@synopsys.com>
Signed-off-by: John Youn <johnyoun@synopsys.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
  • Loading branch information
Razmik Karapetyan authored and Felipe Balbi committed Nov 18, 2016
1 parent c3b22fe commit 01719c2
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions drivers/usb/dwc2/gadget.c
Original file line number Diff line number Diff line change
Expand Up @@ -316,11 +316,6 @@ static void dwc2_hsotg_unmap_dma(struct dwc2_hsotg *hsotg,
struct dwc2_hsotg_req *hs_req)
{
struct usb_request *req = &hs_req->req;

/* ignore this if we're not moving any data */
if (hs_req->req.length == 0)
return;

usb_gadget_unmap_request(&hsotg->gadget, req, hs_ep->dir_in);
}

Expand Down Expand Up @@ -1101,13 +1096,8 @@ static int dwc2_hsotg_map_dma(struct dwc2_hsotg *hsotg,
struct dwc2_hsotg_ep *hs_ep,
struct usb_request *req)
{
struct dwc2_hsotg_req *hs_req = our_req(req);
int ret;

/* if the length is zero, ignore the DMA data */
if (hs_req->req.length == 0)
return 0;

ret = usb_gadget_map_request(&hsotg->gadget, req, hs_ep->dir_in);
if (ret)
goto dma_error;
Expand Down

0 comments on commit 01719c2

Please sign in to comment.