Skip to content

Commit

Permalink
Revert "drm/xe/xe_guc_ads: save/restore OA registers and allowlist regs"
Browse files Browse the repository at this point in the history
This reverts commit 55858fa.

'55858fa7eb2f ("drm/xe/xe_guc_ads: save/restore OA registers and allowlist
regs")' was not properly reviewed and also causes dmesg asserts in
CI. Revert it.

Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/3295
Fixes: 55858fa ("drm/xe/xe_guc_ads: save/restore OA registers and allowlist regs")
Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
Reviewed-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241029200147.1476513-1-ashutosh.dixit@intel.com
  • Loading branch information
Ashutosh Dixit authored and Matt Roper committed Oct 30, 2024
1 parent db38fdb commit 0191fdd
Showing 1 changed file with 0 additions and 14 deletions.
14 changes: 0 additions & 14 deletions drivers/gpu/drm/xe/xe_guc_ads.c
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
#include "regs/xe_engine_regs.h"
#include "regs/xe_gt_regs.h"
#include "regs/xe_guc_regs.h"
#include "regs/xe_oa_regs.h"
#include "xe_bo.h"
#include "xe_gt.h"
#include "xe_gt_ccs_mode.h"
Expand Down Expand Up @@ -741,11 +740,6 @@ static unsigned int guc_mmio_regset_write(struct xe_guc_ads *ads,
guc_mmio_regset_write_one(ads, regset_map, e->reg, count++);
}

for (i = 0; i < RING_MAX_NONPRIV_SLOTS; i++)
guc_mmio_regset_write_one(ads, regset_map,
RING_FORCE_TO_NONPRIV(hwe->mmio_base, i),
count++);

/* Wa_1607983814 */
if (needs_wa_1607983814(xe) && hwe->class == XE_ENGINE_CLASS_RENDER) {
for (i = 0; i < LNCFCMOCS_REG_COUNT; i++) {
Expand All @@ -754,14 +748,6 @@ static unsigned int guc_mmio_regset_write(struct xe_guc_ads *ads,
}
}

guc_mmio_regset_write_one(ads, regset_map, EU_PERF_CNTL0, count++);
guc_mmio_regset_write_one(ads, regset_map, EU_PERF_CNTL1, count++);
guc_mmio_regset_write_one(ads, regset_map, EU_PERF_CNTL2, count++);
guc_mmio_regset_write_one(ads, regset_map, EU_PERF_CNTL3, count++);
guc_mmio_regset_write_one(ads, regset_map, EU_PERF_CNTL4, count++);
guc_mmio_regset_write_one(ads, regset_map, EU_PERF_CNTL5, count++);
guc_mmio_regset_write_one(ads, regset_map, EU_PERF_CNTL6, count++);

return count;
}

Expand Down

0 comments on commit 0191fdd

Please sign in to comment.