Skip to content

Commit

Permalink
cgroup: Use RCU_INIT_POINTER(x, NULL) in cgroup.c
Browse files Browse the repository at this point in the history
This patch replaces rcu_assign_pointer(x, NULL) with
RCU_INIT_POINTER(x, NULL)

The rcu_assign_pointer() ensures that the initialization of a
structure is carried out before storing a pointer to that structure.
And in the case of the NULL pointer, there is no structure to
initialize.  So, rcu_assign_pointer(p, NULL) can be safely converted
to RCU_INIT_POINTER(p, NULL)

Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
  • Loading branch information
Monam Agarwal authored and Tejun Heo committed Mar 24, 2014
1 parent e1b2dc1 commit 01a9714
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion kernel/cgroup.c
Original file line number Diff line number Diff line change
Expand Up @@ -3545,7 +3545,7 @@ static void css_release(struct percpu_ref *ref)
struct cgroup_subsys_state *css =
container_of(ref, struct cgroup_subsys_state, refcnt);

rcu_assign_pointer(css->cgroup->subsys[css->ss->id], NULL);
RCU_INIT_POINTER(css->cgroup->subsys[css->ss->id], NULL);
call_rcu(&css->rcu_head, css_free_rcu_fn);
}

Expand Down

0 comments on commit 01a9714

Please sign in to comment.