Skip to content

Commit

Permalink
genirq: Correctly annotate implicit fall through
Browse files Browse the repository at this point in the history
There is a plan to build the kernel with -Wimplicit-fallthrough. The
fallthrough in __handle_irq_event_percpu() has a fallthrough annotation
which is followed by an additional comment and is not recognized by GCC.

Separate the 'fall through' and the rest of the comment with a dash so the
regular expression used by GCC matches.

Signed-off-by: Mathieu Malaterre <malat@debian.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lkml.kernel.org/r/20190114203633.18557-1-malat@debian.org
  • Loading branch information
Mathieu Malaterre authored and Thomas Gleixner committed Jan 15, 2019
1 parent 44133f7 commit 01cdfa9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion kernel/irq/handle.c
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ irqreturn_t __handle_irq_event_percpu(struct irq_desc *desc, unsigned int *flags

__irq_wake_thread(desc, action);

/* Fall through to add to randomness */
/* Fall through - to add to randomness */
case IRQ_HANDLED:
*flags |= action->flags;
break;
Expand Down

0 comments on commit 01cdfa9

Please sign in to comment.