net: sched: act_ife: fix memory leak in ife init

Free params if tcf_idr_check_alloc() returned error. Fixes: 0190c1d ("net: sched: atomically check-allocate action") Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Vlad Buslov <vladbu@mellanox.com> Signed-off-by: David S. Miller <davem@davemloft.net>
mariux64 · Jul 12, 2018 · 01e866b · 01e866b
1 parent 8dce04f
commit 01e866b
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/net/sched/act_ife.c b/net/sched/act_ife.c
@@ -485,8 +485,10 @@ static int tcf_ife_init(struct net *net, struct nlattr *nla,
 		return -ENOMEM;
 
 	err = tcf_idr_check_alloc(tn, &parm->index, a, bind);
-	if (err < 0)
+	if (err < 0) {
+		kfree(p);
 		return err;
+	}
 	exists = err;
 	if (exists && bind) {
 		kfree(p);