Skip to content

Commit

Permalink
scsi: lpfc: vmid: Add datastructure for supporting VMID in lpfc
Browse files Browse the repository at this point in the history 
Add the primary datastructures needed to implement VMID in the lpfc
driver. Maintain the capability, current state, and hash table for the
vmid/appid along with other information. This implementation supports the
two versions of vmid implementation (app header and priority tagging).

Link: https://lore.kernel.org/r/20210608043556.274139-5-muneendra.kumar@broadcom.com
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Gaurav Srivastava <gaurav.srivastava@broadcom.com>
Signed-off-by: James Smart <jsmart2021@gmail.com>
Signed-off-by: Muneendra Kumar <muneendra.kumar@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
  • Loading branch information
Gaurav Srivastava authored and Martin K. Petersen committed Jun 10, 2021
1 parent 3dbbca7 commit 02169e8
Show file tree
Hide file tree
Showing 5 changed files with 262 additions and 4 deletions.
122 changes: 122 additions & 0 deletions drivers/scsi/lpfc/lpfc.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,64 @@ struct lpfc_stats {
struct lpfc_hba;


#define LPFC_VMID_TIMER 300 /* timer interval in seconds */

#define LPFC_MAX_VMID_SIZE 256
#define LPFC_COMPRESS_VMID_SIZE 16

union lpfc_vmid_io_tag {
u32 app_id; /* App Id vmid */
u8 cs_ctl_vmid; /* Priority tag vmid */
};

#define JIFFIES_PER_HR (HZ * 60 * 60)

struct lpfc_vmid {
u8 flag;
#define LPFC_VMID_SLOT_FREE 0x0
#define LPFC_VMID_SLOT_USED 0x1
#define LPFC_VMID_REQ_REGISTER 0x2
#define LPFC_VMID_REGISTERED 0x4
#define LPFC_VMID_DE_REGISTER 0x8
char host_vmid[LPFC_MAX_VMID_SIZE];
union lpfc_vmid_io_tag un;
struct hlist_node hnode;
u64 io_rd_cnt;
u64 io_wr_cnt;
u8 vmid_len;
u8 delete_inactive; /* Delete if inactive flag 0 = no, 1 = yes */
u32 hash_index;
u64 __percpu *last_io_time;
};

#define lpfc_vmid_is_type_priority_tag(vport)\
(vport->vmid_priority_tagging ? 1 : 0)

#define LPFC_VMID_HASH_SIZE 256
#define LPFC_VMID_HASH_MASK 255
#define LPFC_VMID_HASH_SHIFT 6

struct lpfc_vmid_context {
struct lpfc_vmid *vmp;
struct lpfc_nodelist *nlp;
bool instantiated;
};

struct lpfc_vmid_priority_range {
u8 low;
u8 high;
u8 qos;
};

struct lpfc_vmid_priority_info {
u32 num_descriptors;
struct lpfc_vmid_priority_range *vmid_range;
};

#define QFPA_EVEN_ONLY 0x01
#define QFPA_ODD_ONLY 0x02
#define QFPA_EVEN_ODD 0x03

enum discovery_state {
LPFC_VPORT_UNKNOWN = 0, /* vport state is unknown */
LPFC_VPORT_FAILED = 1, /* vport has failed */
Expand Down Expand Up @@ -443,6 +501,9 @@ struct lpfc_vport {
#define WORKER_RAMP_DOWN_QUEUE 0x800 /* hba: Decrease Q depth */
#define WORKER_RAMP_UP_QUEUE 0x1000 /* hba: Increase Q depth */
#define WORKER_SERVICE_TXQ 0x2000 /* hba: IOCBs on the txq */
#define WORKER_CHECK_INACTIVE_VMID 0x4000 /* hba: check inactive vmids */
#define WORKER_CHECK_VMID_ISSUE_QFPA 0x8000 /* vport: Check if qfpa needs
* to be issued */

struct timer_list els_tmofunc;
struct timer_list delayed_disc_tmo;
Expand All @@ -453,6 +514,8 @@ struct lpfc_vport {
#define FC_LOADING 0x1 /* HBA in process of loading drvr */
#define FC_UNLOADING 0x2 /* HBA in process of unloading drvr */
#define FC_ALLOW_FDMI 0x4 /* port is ready for FDMI requests */
#define FC_ALLOW_VMID 0x8 /* Allow VMID I/Os */
#define FC_DEREGISTER_ALL_APP_ID 0x10 /* Deregister all VMIDs */
/* Vport Config Parameters */
uint32_t cfg_scan_down;
uint32_t cfg_lun_queue_depth;
Expand All @@ -471,9 +534,36 @@ struct lpfc_vport {
uint32_t cfg_tgt_queue_depth;
uint32_t cfg_first_burst_size;
uint32_t dev_loss_tmo_changed;
/* VMID parameters */
u8 lpfc_vmid_host_uuid[LPFC_COMPRESS_VMID_SIZE];
u32 max_vmid; /* maximum VMIDs allowed per port */
u32 cur_vmid_cnt; /* Current VMID count */
#define LPFC_MIN_VMID 4
#define LPFC_MAX_VMID 255
u32 vmid_inactivity_timeout; /* Time after which the VMID */
/* deregisters from switch */
u32 vmid_priority_tagging;
#define LPFC_VMID_PRIO_TAG_DISABLE 0 /* Disable */
#define LPFC_VMID_PRIO_TAG_SUP_TARGETS 1 /* Allow supported targets only */
#define LPFC_VMID_PRIO_TAG_ALL_TARGETS 2 /* Allow all targets */
unsigned long *vmid_priority_range;
#define LPFC_VMID_MAX_PRIORITY_RANGE 256
#define LPFC_VMID_PRIORITY_BITMAP_SIZE 32
u8 vmid_flag;
#define LPFC_VMID_IN_USE 0x1
#define LPFC_VMID_ISSUE_QFPA 0x2
#define LPFC_VMID_QFPA_CMPL 0x4
#define LPFC_VMID_QOS_ENABLED 0x8
#define LPFC_VMID_TIMER_ENBLD 0x10
struct fc_qfpa_res *qfpa_res;

struct fc_vport *fc_vport;

struct lpfc_vmid *vmid;
DECLARE_HASHTABLE(hash_table, 8);
rwlock_t vmid_lock;
struct lpfc_vmid_priority_info vmid_priority;

#ifdef CONFIG_SCSI_LPFC_DEBUG_FS
struct dentry *debug_disc_trc;
struct dentry *debug_nodelist;
Expand Down Expand Up @@ -940,6 +1030,13 @@ struct lpfc_hba {
struct nvmet_fc_target_port *targetport;
lpfc_vpd_t vpd; /* vital product data */

u32 cfg_max_vmid; /* maximum VMIDs allowed per port */
u32 cfg_vmid_app_header;
#define LPFC_VMID_APP_HEADER_DISABLE 0
#define LPFC_VMID_APP_HEADER_ENABLE 1
u32 cfg_vmid_priority_tagging;
u32 cfg_vmid_inactivity_timeout; /* Time after which the VMID */
/* deregisters from switch */
struct pci_dev *pcidev;
struct list_head work_list;
uint32_t work_ha; /* Host Attention Bits for WT */
Expand Down Expand Up @@ -1180,6 +1277,7 @@ struct lpfc_hba {
struct list_head ct_ev_waiters;
struct unsol_rcv_ct_ctx ct_ctx[LPFC_CT_CTX_MAX];
uint32_t ctx_idx;
struct timer_list inactive_vmid_poll;

/* RAS Support */
struct lpfc_ras_fwlog ras_fwlog;
Expand Down Expand Up @@ -1421,3 +1519,27 @@ static const char *routine(enum enum_name table_key) \
} \
return name; \
}

/**
* lpfc_is_vmid_enabled - returns if VMID is enabled for either switch types
* @phba: Pointer to HBA context object.
*
* Relationship between the enable, target support and if vmid tag is required
* for the particular combination
* ---------------------------------------------------
* Switch Enable Flag Target Support VMID Needed
* ---------------------------------------------------
* App Id 0 NA N
* App Id 1 0 N
* App Id 1 1 Y
* Pr Tag 0 NA N
* Pr Tag 1 0 N
* Pr Tag 1 1 Y
* Pr Tag 2 * Y
---------------------------------------------------
*
**/
static inline int lpfc_is_vmid_enabled(struct lpfc_hba *phba)
{
return phba->cfg_vmid_app_header || phba->cfg_vmid_priority_tagging;
}
11 changes: 11 additions & 0 deletions drivers/scsi/lpfc/lpfc_crtn.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -608,3 +608,14 @@ extern unsigned long lpfc_no_hba_reset[];
extern union lpfc_wqe128 lpfc_iread_cmd_template;
extern union lpfc_wqe128 lpfc_iwrite_cmd_template;
extern union lpfc_wqe128 lpfc_icmnd_cmd_template;

/* vmid interface */
int lpfc_vmid_uvem(struct lpfc_vport *vport, struct lpfc_vmid *vmid, bool ins);
uint32_t lpfc_vmid_get_cs_ctl(struct lpfc_vport *vport);
int lpfc_vmid_cmd(struct lpfc_vport *vport,
int cmdcode, struct lpfc_vmid *vmid);
int lpfc_vmid_hash_fn(const char *vmid, int len);
struct lpfc_vmid *lpfc_get_vmid_from_hashtable(struct lpfc_vport *vport,
uint32_t hash, uint8_t *buf);
void lpfc_vmid_vport_cleanup(struct lpfc_vport *vport);
int lpfc_issue_els_qfpa(struct lpfc_vport *vport);
1 change: 1 addition & 0 deletions drivers/scsi/lpfc/lpfc_disc.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ struct lpfc_nodelist {
uint8_t nlp_fcp_info; /* class info, bits 0-3 */
#define NLP_FCP_2_DEVICE 0x10 /* FCP-2 device */
u8 nlp_nvme_info; /* NVME NSLER Support */
uint8_t vmid_support; /* destination VMID support */
#define NLP_NVME_NSLER 0x1 /* NVME NSLER device */

struct timer_list nlp_delayfunc; /* Used for delayed ELS cmds */
Expand Down
124 changes: 120 additions & 4 deletions drivers/scsi/lpfc/lpfc_hw.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,7 @@ struct lpfc_sli_ct_request {
#define SLI_CT_ACCESS_DENIED 0x10
#define SLI_CT_INVALID_PORT_ID 0x11
#define SLI_CT_DATABASE_EMPTY 0x12
#define SLI_CT_APP_ID_NOT_AVAILABLE 0x40

/*
* Name Server Command Codes
Expand Down Expand Up @@ -400,16 +401,16 @@ struct csp {
uint16_t altBbCredit:1; /* FC Word 1, bit 27 */
uint16_t edtovResolution:1; /* FC Word 1, bit 26 */
uint16_t multicast:1; /* FC Word 1, bit 25 */
uint16_t broadcast:1; /* FC Word 1, bit 24 */
uint16_t app_hdr_support:1; /* FC Word 1, bit 24 */

uint16_t huntgroup:1; /* FC Word 1, bit 23 */
uint16_t priority_tagging:1; /* FC Word 1, bit 23 */
uint16_t simplex:1; /* FC Word 1, bit 22 */
uint16_t word1Reserved1:3; /* FC Word 1, bit 21:19 */
uint16_t dhd:1; /* FC Word 1, bit 18 */
uint16_t contIncSeqCnt:1; /* FC Word 1, bit 17 */
uint16_t payloadlength:1; /* FC Word 1, bit 16 */
#else /* __LITTLE_ENDIAN_BITFIELD */
uint16_t broadcast:1; /* FC Word 1, bit 24 */
uint16_t app_hdr_support:1; /* FC Word 1, bit 24 */
uint16_t multicast:1; /* FC Word 1, bit 25 */
uint16_t edtovResolution:1; /* FC Word 1, bit 26 */
uint16_t altBbCredit:1; /* FC Word 1, bit 27 */
Expand All @@ -423,7 +424,7 @@ struct csp {
uint16_t dhd:1; /* FC Word 1, bit 18 */
uint16_t word1Reserved1:3; /* FC Word 1, bit 21:19 */
uint16_t simplex:1; /* FC Word 1, bit 22 */
uint16_t huntgroup:1; /* FC Word 1, bit 23 */
uint16_t priority_tagging:1; /* FC Word 1, bit 23 */
#endif

uint8_t bbRcvSizeMsb; /* Upper nibble is reserved */
Expand Down Expand Up @@ -607,6 +608,8 @@ struct fc_vft_header {
#define ELS_CMD_LIRR 0x7A000000
#define ELS_CMD_LCB 0x81000000
#define ELS_CMD_FPIN 0x16000000
#define ELS_CMD_QFPA 0xB0000000
#define ELS_CMD_UVEM 0xB1000000
#else /* __LITTLE_ENDIAN_BITFIELD */
#define ELS_CMD_MASK 0xffff
#define ELS_RSP_MASK 0xff
Expand Down Expand Up @@ -649,6 +652,8 @@ struct fc_vft_header {
#define ELS_CMD_LIRR 0x7A
#define ELS_CMD_LCB 0x81
#define ELS_CMD_FPIN ELS_FPIN
#define ELS_CMD_QFPA 0xB0
#define ELS_CMD_UVEM 0xB1
#endif

/*
Expand Down Expand Up @@ -1317,6 +1322,117 @@ struct fc_rdp_res_frame {
};


/* UVEM */

#define LPFC_UVEM_SIZE 60
#define LPFC_UVEM_VEM_ID_DESC_SIZE 16
#define LPFC_UVEM_VE_MAP_DESC_SIZE 20

#define VEM_ID_DESC_TAG 0x0001000A
struct lpfc_vem_id_desc {
uint32_t tag;
uint32_t length;
uint8_t vem_id[16];
};

#define LPFC_QFPA_SIZE 4

#define INSTANTIATED_VE_DESC_TAG 0x0001000B
struct instantiated_ve_desc {
uint32_t tag;
uint32_t length;
uint8_t global_vem_id[16];
uint32_t word6;
#define lpfc_instantiated_local_id_SHIFT 0
#define lpfc_instantiated_local_id_MASK 0x000000ff
#define lpfc_instantiated_local_id_WORD word6
#define lpfc_instantiated_nport_id_SHIFT 8
#define lpfc_instantiated_nport_id_MASK 0x00ffffff
#define lpfc_instantiated_nport_id_WORD word6
};

#define DEINSTANTIATED_VE_DESC_TAG 0x0001000C
struct deinstantiated_ve_desc {
uint32_t tag;
uint32_t length;
uint8_t global_vem_id[16];
uint32_t word6;
#define lpfc_deinstantiated_nport_id_SHIFT 0
#define lpfc_deinstantiated_nport_id_MASK 0x000000ff
#define lpfc_deinstantiated_nport_id_WORD word6
#define lpfc_deinstantiated_local_id_SHIFT 24
#define lpfc_deinstantiated_local_id_MASK 0x00ffffff
#define lpfc_deinstantiated_local_id_WORD word6
};

/* Query Fabric Priority Allocation Response */
#define LPFC_PRIORITY_RANGE_DESC_SIZE 12

struct priority_range_desc {
uint32_t tag;
uint32_t length;
uint8_t lo_range;
uint8_t hi_range;
uint8_t qos_priority;
uint8_t local_ve_id;
};

struct fc_qfpa_res {
uint32_t reply_sequence; /* LS_ACC or LS_RJT */
uint32_t length; /* FC Word 1 */
struct priority_range_desc desc[1];
};

/* Application Server command code */
/* VMID */

#define SLI_CT_APP_SEV_Subtypes 0x20 /* Application Server subtype */

#define SLI_CTAS_GAPPIA_ENT 0x0100 /* Get Application Identifier */
#define SLI_CTAS_GALLAPPIA 0x0101 /* Get All Application Identifier */
#define SLI_CTAS_GALLAPPIA_ID 0x0102 /* Get All Application Identifier */
/* for Nport */
#define SLI_CTAS_GAPPIA_IDAPP 0x0103 /* Get Application Identifier */
/* for Nport */
#define SLI_CTAS_RAPP_IDENT 0x0200 /* Register Application Identifier */
#define SLI_CTAS_DAPP_IDENT 0x0300 /* Deregister Application */
/* Identifier */
#define SLI_CTAS_DALLAPP_ID 0x0301 /* Deregister All Application */
/* Identifier */

struct entity_id_object {
uint8_t entity_id_len;
uint8_t entity_id[255]; /* VM UUID */
};

struct app_id_object {
uint32_t port_id;
uint32_t app_id;
struct entity_id_object obj;
};

struct lpfc_vmid_rapp_ident_list {
uint32_t no_of_objects;
struct entity_id_object obj[1];
};

struct lpfc_vmid_dapp_ident_list {
uint32_t no_of_objects;
struct entity_id_object obj[1];
};

#define GALLAPPIA_ID_LAST 0x80
struct lpfc_vmid_gallapp_ident_list {
uint8_t control;
uint8_t reserved[3];
struct app_id_object app_id;
};

#define RAPP_IDENT_OFFSET (offsetof(struct lpfc_sli_ct_request, un) + 4)
#define DAPP_IDENT_OFFSET (offsetof(struct lpfc_sli_ct_request, un) + 4)
#define GALLAPPIA_ID_SIZE (offsetof(struct lpfc_sli_ct_request, un) + 4)
#define DALLAPP_ID_SIZE (offsetof(struct lpfc_sli_ct_request, un) + 4)

/******** FDMI ********/

/* lpfc_sli_ct_request defines the CT_IU preamble for FDMI commands */
Expand Down
8 changes: 8 additions & 0 deletions drivers/scsi/lpfc/lpfc_sli.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,12 @@ typedef enum _lpfc_ctx_cmd {
LPFC_CTX_HOST
} lpfc_ctx_cmd;

union lpfc_vmid_iocb_tag {
uint32_t app_id;
uint8_t cs_ctl_vmid;
struct lpfc_vmid_context *vmid_context; /* UVEM context information */
};

struct lpfc_cq_event {
struct list_head list;
uint16_t hdwq;
Expand Down Expand Up @@ -100,6 +106,7 @@ struct lpfc_iocbq {
#define LPFC_IO_NVME 0x200000 /* NVME FCP command */
#define LPFC_IO_NVME_LS 0x400000 /* NVME LS command */
#define LPFC_IO_NVMET 0x800000 /* NVMET command */
#define LPFC_IO_VMID 0x1000000 /* VMID tagged IO */

uint32_t drvrTimeout; /* driver timeout in seconds */
struct lpfc_vport *vport;/* virtual port pointer */
Expand All @@ -115,6 +122,7 @@ struct lpfc_iocbq {
struct lpfc_node_rrq *rrq;
} context_un;

union lpfc_vmid_iocb_tag vmid_tag;
void (*fabric_iocb_cmpl)(struct lpfc_hba *, struct lpfc_iocbq *,
struct lpfc_iocbq *);
void (*wait_iocb_cmpl)(struct lpfc_hba *, struct lpfc_iocbq *,
Expand Down

0 comments on commit 02169e8

Please sign in to comment.