Skip to content

Commit

Permalink
ASoC: meson: aiu: simplify component addition
Browse files Browse the repository at this point in the history
Now that the component name is unique within ASoC, there is no need to
hack the debugfs prefix to add more than one ASoC component to a linux
device. Remove the unnecessary function and use
snd_soc_register_component() directly.

Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Link: https://lore.kernel.org/r/20200217092019.433402-1-jbrunet@baylibre.com
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Jerome Brunet authored and Mark Brown committed Feb 17, 2020
1 parent f07980d commit 0247142
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 36 deletions.
7 changes: 3 additions & 4 deletions sound/soc/meson/aiu-acodec-ctrl.c
Original file line number Diff line number Diff line change
Expand Up @@ -197,8 +197,7 @@ static const struct snd_soc_component_driver aiu_acodec_ctrl_component = {

int aiu_acodec_ctrl_register_component(struct device *dev)
{
return aiu_add_component(dev, &aiu_acodec_ctrl_component,
aiu_acodec_ctrl_dai_drv,
ARRAY_SIZE(aiu_acodec_ctrl_dai_drv),
"acodec");
return snd_soc_register_component(dev, &aiu_acodec_ctrl_component,
aiu_acodec_ctrl_dai_drv,
ARRAY_SIZE(aiu_acodec_ctrl_dai_drv));
}
7 changes: 3 additions & 4 deletions sound/soc/meson/aiu-codec-ctrl.c
Original file line number Diff line number Diff line change
Expand Up @@ -144,9 +144,8 @@ static const struct snd_soc_component_driver aiu_hdmi_ctrl_component = {

int aiu_hdmi_ctrl_register_component(struct device *dev)
{
return aiu_add_component(dev, &aiu_hdmi_ctrl_component,
aiu_hdmi_ctrl_dai_drv,
ARRAY_SIZE(aiu_hdmi_ctrl_dai_drv),
"hdmi");
return snd_soc_register_component(dev, &aiu_hdmi_ctrl_component,
aiu_hdmi_ctrl_dai_drv,
ARRAY_SIZE(aiu_hdmi_ctrl_dai_drv));
}

20 changes: 0 additions & 20 deletions sound/soc/meson/aiu.c
Original file line number Diff line number Diff line change
Expand Up @@ -71,26 +71,6 @@ int aiu_of_xlate_dai_name(struct snd_soc_component *component,
return 0;
}

int aiu_add_component(struct device *dev,
const struct snd_soc_component_driver *component_driver,
struct snd_soc_dai_driver *dai_drv,
int num_dai,
const char *debugfs_prefix)
{
struct snd_soc_component *component;

component = devm_kzalloc(dev, sizeof(*component), GFP_KERNEL);
if (!component)
return -ENOMEM;

#ifdef CONFIG_DEBUG_FS
component->debugfs_prefix = debugfs_prefix;
#endif

return snd_soc_add_component(dev, component, component_driver,
dai_drv, num_dai);
}

static int aiu_cpu_of_xlate_dai_name(struct snd_soc_component *component,
struct of_phandle_args *args,
const char **dai_name)
Expand Down
8 changes: 0 additions & 8 deletions sound/soc/meson/aiu.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,7 @@ struct clk;
struct clk_bulk_data;
struct device;
struct of_phandle_args;
struct snd_soc_component_driver;
struct snd_soc_dai;
struct snd_soc_dai_driver;
struct snd_soc_dai_ops;

enum aiu_clk_ids {
Expand Down Expand Up @@ -45,12 +43,6 @@ int aiu_of_xlate_dai_name(struct snd_soc_component *component,
const char **dai_name,
unsigned int component_id);

int aiu_add_component(struct device *dev,
const struct snd_soc_component_driver *component_driver,
struct snd_soc_dai_driver *dai_drv,
int num_dai,
const char *debugfs_prefix);

int aiu_hdmi_ctrl_register_component(struct device *dev);
int aiu_acodec_ctrl_register_component(struct device *dev);

Expand Down

0 comments on commit 0247142

Please sign in to comment.