Skip to content

Commit

Permalink
net/mlx5e: Use single argument for the esw representor build params h…
Browse files Browse the repository at this point in the history
…elper

This is prep step towards adding dedicated uplink representor.

The patch doesn't change any functionality.

Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
  • Loading branch information
Or Gerlitz authored and Saeed Mahameed committed Dec 17, 2018
1 parent 915fe1a commit 025380b
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
Original file line number Diff line number Diff line change
Expand Up @@ -1205,17 +1205,19 @@ static const struct net_device_ops mlx5e_netdev_ops_rep = {
.ndo_change_mtu = mlx5e_change_rep_mtu,
};

static void mlx5e_build_rep_params(struct mlx5_core_dev *mdev,
struct mlx5e_params *params,
struct mlx5e_rss_params *rss_params,
u16 mtu)
static void mlx5e_build_rep_params(struct net_device *netdev)
{
struct mlx5e_priv *priv = netdev_priv(netdev);
struct mlx5_core_dev *mdev = priv->mdev;
struct mlx5e_params *params;

u8 cq_period_mode = MLX5_CAP_GEN(mdev, cq_period_start_from_cqe) ?
MLX5_CQ_PERIOD_MODE_START_FROM_CQE :
MLX5_CQ_PERIOD_MODE_START_FROM_EQE;

params = &priv->channels.params;
params->hard_mtu = MLX5E_ETH_HARD_MTU;
params->sw_mtu = mtu;
params->sw_mtu = netdev->mtu;
params->log_sq_size = MLX5E_REP_PARAMS_LOG_SQ_SIZE;

/* RQ */
Expand All @@ -1230,7 +1232,7 @@ static void mlx5e_build_rep_params(struct mlx5_core_dev *mdev,
mlx5_query_min_inline(mdev, &params->tx_min_inline_mode);

/* RSS */
mlx5e_build_rss_params(rss_params, params->num_channels);
mlx5e_build_rss_params(&priv->rss_params, params->num_channels);
}

static void mlx5e_build_rep_netdev(struct net_device *netdev)
Expand Down Expand Up @@ -1283,8 +1285,7 @@ static int mlx5e_init_rep(struct mlx5_core_dev *mdev,
priv->channels.params.num_channels =
mlx5e_get_netdev_max_channels(netdev);

mlx5e_build_rep_params(mdev, &priv->channels.params,
&priv->rss_params, netdev->mtu);
mlx5e_build_rep_params(netdev);
mlx5e_build_rep_netdev(netdev);

mlx5e_timestamp_init(priv);
Expand Down

0 comments on commit 025380b

Please sign in to comment.