Skip to content

Commit

Permalink
drm/rockchip: inno_hdmi: reorder clk_disable_unprepare call in unbind
Browse files Browse the repository at this point in the history
In bind the clk_prepare_enable of the HDMI pclk is called before adding the
i2c_adapter. So it should be the other way around in unbind, first remove
the i2c_adapter and then call the clk_disable_unprepare.

Fixes: 412d4ae ("drm/rockchip: hdmi: add Innosilicon HDMI support")
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
Signed-off-by: Thierry Escande <thierry.escande@collabora.com>
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20180302175757.28192-4-enric.balletbo@collabora.com
  • Loading branch information
Jeffy Chen authored and Heiko Stuebner committed Mar 8, 2018
1 parent 61b5ff9 commit 028a9e5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpu/drm/rockchip/inno_hdmi.c
Original file line number Diff line number Diff line change
Expand Up @@ -906,8 +906,8 @@ static void inno_hdmi_unbind(struct device *dev, struct device *master,
hdmi->connector.funcs->destroy(&hdmi->connector);
hdmi->encoder.funcs->destroy(&hdmi->encoder);

clk_disable_unprepare(hdmi->pclk);
i2c_put_adapter(hdmi->ddc);
clk_disable_unprepare(hdmi->pclk);
}

static const struct component_ops inno_hdmi_ops = {
Expand Down

0 comments on commit 028a9e5

Please sign in to comment.