Skip to content

Commit

Permalink
x86: Don't use the EFI reboot method by default
Browse files Browse the repository at this point in the history
commit f70e957 upstream.

Testing suggests that at least some Lenovos and some Intels will
fail to reboot via EFI, attempting to jump to an unmapped
physical address. In the long run we could handle this by
providing a page table with a 1:1 mapping of physical addresses,
but for now it's probably just easier to assume that ACPI or
legacy methods will be present and reboot via those.

Signed-off-by: Matthew Garrett <mjg@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Alan Cox <alan@linux.intel.com>
Link: http://lkml.kernel.org/r/1309985557-15350-1-git-send-email-mjg@redhat.com
Signed-off-by: Ingo Molnar <mingo@elte.hu>
[PG: in 2.6.34, file is x86/platform/efi/efi.c --> x86/kernel/efi.c]
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
  • Loading branch information
Matthew Garrett authored and Paul Gortmaker committed Jan 16, 2013
1 parent f9f3d32 commit 02ce778
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions arch/x86/kernel/efi.c
Original file line number Diff line number Diff line change
Expand Up @@ -459,9 +459,6 @@ void __init efi_init(void)
x86_platform.set_wallclock = efi_set_rtc_mmss;
#endif

/* Setup for EFI runtime service */
reboot_type = BOOT_EFI;

#if EFI_DEBUG
print_efi_memmap();
#endif
Expand Down

0 comments on commit 02ce778

Please sign in to comment.