Skip to content

Commit

Permalink
nvme-fc: release io queues to allow fast fail
Browse files Browse the repository at this point in the history
Rather than leaving io queues quiesced after tearing down an association,
restart them. This allows ios to be replayed, with fastfail ios terminating
and non-fastfail getting into loops of retry.

This follows rdma's lead.

Signed-off-by: James Smart <james.smart@broadcom.com>
Reviewed-by: Sagi Grimberg <sagi@grimber.me>
Signed-off-by: Christoph Hellwig <hch@lst.de>
  • Loading branch information
James Smart authored and Christoph Hellwig committed Jun 21, 2018
1 parent d68a90e commit 02d62a8
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/nvme/host/fc.c
Original file line number Diff line number Diff line change
Expand Up @@ -2790,6 +2790,9 @@ nvme_fc_delete_association(struct nvme_fc_ctrl *ctrl)
/* re-enable the admin_q so anything new can fast fail */
blk_mq_unquiesce_queue(ctrl->ctrl.admin_q);

/* resume the io queues so that things will fast fail */
nvme_start_queues(&ctrl->ctrl);

nvme_fc_ctlr_inactive_on_rport(ctrl);
}

Expand All @@ -2804,9 +2807,6 @@ nvme_fc_delete_ctrl(struct nvme_ctrl *nctrl)
* waiting for io to terminate
*/
nvme_fc_delete_association(ctrl);

/* resume the io queues so that things will fast fail */
nvme_start_queues(nctrl);
}

static void
Expand Down

0 comments on commit 02d62a8

Please sign in to comment.