Skip to content

Commit

Permalink
usb: gadget: add 'quirk_stall_not_supp' to usb_gadget
Browse files Browse the repository at this point in the history
Due to some UDC controllers may not support stalling, usb gadget layer
needs to provide a generic way to inform gadget functions about non-standard
hardware limitations.

This patch adds 'quirk_stall_not_supp' field to struct usb_gadget and helper
function gadget_is_stall_supported(). It also sets 'quirk_stall_not_supp'
to 1 in at91_udc driver, which has such limitation.

Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
  • Loading branch information
Robert Baldyga authored and Felipe Balbi committed Jul 30, 2015
1 parent ffd9a0f commit 02ded1b
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
1 change: 1 addition & 0 deletions drivers/usb/gadget/udc/at91_udc.c
Original file line number Diff line number Diff line change
Expand Up @@ -825,6 +825,7 @@ static void udc_reinit(struct at91_udc *udc)

INIT_LIST_HEAD(&udc->gadget.ep_list);
INIT_LIST_HEAD(&udc->gadget.ep0->ep_list);
udc->gadget.quirk_stall_not_supp = 1;

for (i = 0; i < NUM_ENDPOINTS; i++) {
struct at91_ep *ep = &udc->ep[i];
Expand Down
10 changes: 10 additions & 0 deletions include/linux/usb/gadget.h
Original file line number Diff line number Diff line change
Expand Up @@ -573,6 +573,7 @@ struct usb_gadget {
unsigned a_alt_hnp_support:1;
unsigned quirk_ep_out_aligned_size:1;
unsigned quirk_altset_not_supp:1;
unsigned quirk_stall_not_supp:1;
unsigned is_selfpowered:1;
unsigned deactivated:1;
unsigned connected:1;
Expand Down Expand Up @@ -620,6 +621,15 @@ static inline int gadget_is_altset_supported(struct usb_gadget *g)
return !g->quirk_altset_not_supp;
}

/**
* gadget_is_stall_supported - return true iff the hardware supports stalling
* @g: controller to check for quirk
*/
static inline int gadget_is_stall_supported(struct usb_gadget *g)
{
return !g->quirk_stall_not_supp;
}

/**
* gadget_is_dualspeed - return true iff the hardware handles high speed
* @g: controller that might support both high and full speeds
Expand Down

0 comments on commit 02ded1b

Please sign in to comment.