Skip to content

Commit

Permalink
Merge branch 'timers-fixes-for-linus' of git://git.kernel.org/pub/scm…
Browse files Browse the repository at this point in the history
…/linux/kernel/git/tip/linux-2.6-tip

* 'timers-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip:
  posix-cpu-timers: Rcu_read_lock/unlock protect find_task_by_vpid call
  • Loading branch information
Linus Torvalds committed Nov 26, 2010
2 parents fbe6c40 + c0deae8 commit 0318755
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions kernel/posix-cpu-timers.c
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,13 @@ static int check_clock(const clockid_t which_clock)
if (pid == 0)
return 0;

read_lock(&tasklist_lock);
rcu_read_lock();
p = find_task_by_vpid(pid);
if (!p || !(CPUCLOCK_PERTHREAD(which_clock) ?
same_thread_group(p, current) : thread_group_leader(p))) {
same_thread_group(p, current) : has_group_leader_pid(p))) {
error = -EINVAL;
}
read_unlock(&tasklist_lock);
rcu_read_unlock();

return error;
}
Expand Down Expand Up @@ -390,7 +390,7 @@ int posix_cpu_timer_create(struct k_itimer *new_timer)

INIT_LIST_HEAD(&new_timer->it.cpu.entry);

read_lock(&tasklist_lock);
rcu_read_lock();
if (CPUCLOCK_PERTHREAD(new_timer->it_clock)) {
if (pid == 0) {
p = current;
Expand All @@ -404,7 +404,7 @@ int posix_cpu_timer_create(struct k_itimer *new_timer)
p = current->group_leader;
} else {
p = find_task_by_vpid(pid);
if (p && !thread_group_leader(p))
if (p && !has_group_leader_pid(p))
p = NULL;
}
}
Expand All @@ -414,7 +414,7 @@ int posix_cpu_timer_create(struct k_itimer *new_timer)
} else {
ret = -EINVAL;
}
read_unlock(&tasklist_lock);
rcu_read_unlock();

return ret;
}
Expand Down

0 comments on commit 0318755

Please sign in to comment.