Skip to content

Commit

Permalink
ARM: move memory layout sanity checking before meminfo initialization
Browse files Browse the repository at this point in the history
Ensure that the meminfo array is sanity checked before we pass the
memory to memblock.  This helps to ensure that memblock and meminfo
agree on the dimensions of memory, especially when more memory is
passed than the kernel can deal with.

Acked-by: Nicolas Pitre <nicolas.pitre@linaro.org>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
  • Loading branch information
Russell King committed Jul 5, 2011
1 parent 6f96521 commit 0371d3f
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 2 deletions.
2 changes: 2 additions & 0 deletions arch/arm/kernel/setup.c
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ __setup("fpe=", fpe_setup);
#endif

extern void paging_init(struct machine_desc *desc);
extern void sanity_check_meminfo(void);
extern void reboot_setup(char *str);

unsigned int processor_id;
Expand Down Expand Up @@ -900,6 +901,7 @@ void __init setup_arch(char **cmdline_p)

parse_early_param();

sanity_check_meminfo();
arm_memblock_init(&meminfo, mdesc);

paging_init(mdesc);
Expand Down
5 changes: 3 additions & 2 deletions arch/arm/mm/mmu.c
Original file line number Diff line number Diff line change
Expand Up @@ -759,7 +759,7 @@ early_param("vmalloc", early_vmalloc);

static phys_addr_t lowmem_limit __initdata = 0;

static void __init sanity_check_meminfo(void)
void __init sanity_check_meminfo(void)
{
int i, j, highmem = 0;

Expand Down Expand Up @@ -1032,8 +1032,9 @@ void __init paging_init(struct machine_desc *mdesc)
{
void *zero_page;

memblock_set_current_limit(lowmem_limit);

build_mem_type_table();
sanity_check_meminfo();
prepare_page_table();
map_lowmem();
devicemaps_init(mdesc);
Expand Down
4 changes: 4 additions & 0 deletions arch/arm/mm/nommu.c
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ void __init arm_mm_memblock_reserve(void)
memblock_reserve(CONFIG_VECTORS_BASE, PAGE_SIZE);
}

void __init sanity_check_meminfo(void)
{
}

/*
* paging_init() sets up the page tables, initialises the zone memory
* maps, and sets up the zero page, bad page and bad page tables.
Expand Down

0 comments on commit 0371d3f

Please sign in to comment.