Skip to content

Commit

Permalink
i2c: xiic: Remove the disabling of interrupts
Browse files Browse the repository at this point in the history
Currently the interrupts are disabled at the start of the
isr and enabled at the end of the isr. Remove the same.

In case the slave device NACKs the transaction while in the isr
the transfer will continue and the NACK interrupt will arrive
only after the isr is serviced.

Signed-off-by: Shubhrajyoti Datta <shubhraj@xilinx.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
  • Loading branch information
Shubhrajyoti Datta authored and Wolfram Sang committed Aug 10, 2015
1 parent 51fcce8 commit 0387fc1
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions drivers/i2c/busses/i2c-xiic.c
Original file line number Diff line number Diff line change
@@ -604,14 +604,11 @@ static irqreturn_t xiic_isr(int irq, void *dev_id)
struct xiic_i2c *i2c = dev_id;

spin_lock(&i2c->lock);
/* disable interrupts globally */
xiic_setreg32(i2c, XIIC_DGIER_OFFSET, 0);

dev_dbg(i2c->adap.dev.parent, "%s entry\n", __func__);

xiic_process(i2c);

xiic_setreg32(i2c, XIIC_DGIER_OFFSET, XIIC_GINTR_ENABLE_MASK);
spin_unlock(&i2c->lock);

return IRQ_HANDLED;

0 comments on commit 0387fc1

Please sign in to comment.