Skip to content

Commit

Permalink
net: qcom/emac: add ethtool support for setting ring parameters
Browse files Browse the repository at this point in the history
Implement the set_ringparam method, which allows the user to specify
the size of the TX and RX descriptor rings.  The values are constrained
to the limits of the hardware.

Since the driver does not use separate queues for mini or jumbo frames,
attempts to set those values are rejected.

If the interface is already running when the setting is changed, then
the interface is reset.

Signed-off-by: Timur Tabi <timur@codeaurora.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Timur Tabi authored and David S. Miller committed Feb 9, 2017
1 parent c4e7bee commit 038b940
Showing 1 changed file with 24 additions and 0 deletions.
24 changes: 24 additions & 0 deletions drivers/net/ethernet/qualcomm/emac/emac-ethtool.c
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,29 @@ static void emac_get_ringparam(struct net_device *netdev,
ring->tx_pending = adpt->tx_desc_cnt;
}

static int emac_set_ringparam(struct net_device *netdev,
struct ethtool_ringparam *ring)
{
struct emac_adapter *adpt = netdev_priv(netdev);

/* We don't have separate queues/rings for small/large frames, so
* reject any attempt to specify those values separately.
*/
if (ring->rx_mini_pending || ring->rx_jumbo_pending)
return -EINVAL;

adpt->tx_desc_cnt =
clamp_val(ring->tx_pending, EMAC_MIN_TX_DESCS, EMAC_MAX_TX_DESCS);

adpt->rx_desc_cnt =
clamp_val(ring->rx_pending, EMAC_MIN_RX_DESCS, EMAC_MAX_RX_DESCS);

if (netif_running(netdev))
return emac_reinit_locked(adpt);

return 0;
}

static void emac_get_pauseparam(struct net_device *netdev,
struct ethtool_pauseparam *pause)
{
Expand Down Expand Up @@ -219,6 +242,7 @@ static const struct ethtool_ops emac_ethtool_ops = {
.get_ethtool_stats = emac_get_ethtool_stats,

.get_ringparam = emac_get_ringparam,
.set_ringparam = emac_set_ringparam,

.get_pauseparam = emac_get_pauseparam,
.set_pauseparam = emac_set_pauseparam,
Expand Down

0 comments on commit 038b940

Please sign in to comment.