Skip to content

Commit

Permalink
drm/i915: Remove unused i915_err_print_instdone
Browse files Browse the repository at this point in the history
Just a simple code cleanup, below commit forgot to remove a
function which it made unused:

 commit eaa14c2
 Author: Chris Wilson <chris@chris-wilson.co.uk>
 Date:   Wed Oct 19 13:52:03 2016 +0100

  drm/i915: Stop reporting error details in dmesg as well as the error-state

  As we already capture all the information from the registers into the
  error-state, also dumping that to dmesg just generates noise that upsets
  CI and users alike (and doesn't provide us with any more information).

v2: Chris Wilson dag out the relevant commit. Commit msg updated.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20170727110113.16942-1-tvrtko.ursulin@linux.intel.com
  • Loading branch information
Tvrtko Ursulin committed Jul 28, 2017
1 parent 5a9cfff commit 03e0c83
Showing 1 changed file with 0 additions and 26 deletions.
26 changes: 0 additions & 26 deletions drivers/gpu/drm/i915/i915_irq.c
Original file line number Diff line number Diff line change
Expand Up @@ -2640,32 +2640,6 @@ static void i915_reset_device(struct drm_i915_private *dev_priv)
KOBJ_CHANGE, reset_done_event);
}

static inline void
i915_err_print_instdone(struct drm_i915_private *dev_priv,
struct intel_instdone *instdone)
{
int slice;
int subslice;

pr_err(" INSTDONE: 0x%08x\n", instdone->instdone);

if (INTEL_GEN(dev_priv) <= 3)
return;

pr_err(" SC_INSTDONE: 0x%08x\n", instdone->slice_common);

if (INTEL_GEN(dev_priv) <= 6)
return;

for_each_instdone_slice_subslice(dev_priv, slice, subslice)
pr_err(" SAMPLER_INSTDONE[%d][%d]: 0x%08x\n",
slice, subslice, instdone->sampler[slice][subslice]);

for_each_instdone_slice_subslice(dev_priv, slice, subslice)
pr_err(" ROW_INSTDONE[%d][%d]: 0x%08x\n",
slice, subslice, instdone->row[slice][subslice]);
}

static void i915_clear_error_registers(struct drm_i915_private *dev_priv)
{
u32 eir;
Expand Down

0 comments on commit 03e0c83

Please sign in to comment.