Skip to content

Commit

Permalink
sh: no need to check return value of debugfs_create functions
Browse files Browse the repository at this point in the history
When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: Rich Felker <dalias@libc.org>
Cc: <linux-sh@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Greg Kroah-Hartman committed Jun 3, 2019
1 parent 2fcc6e2 commit 03eb2a0
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 50 deletions.
3 changes: 0 additions & 3 deletions arch/sh/kernel/kdebugfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@ EXPORT_SYMBOL(arch_debugfs_dir);
static int __init arch_kdebugfs_init(void)
{
arch_debugfs_dir = debugfs_create_dir("sh", NULL);
if (!arch_debugfs_dir)
return -ENOMEM;

return 0;
}
arch_initcall(arch_kdebugfs_init);
11 changes: 3 additions & 8 deletions arch/sh/mm/asids-debugfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,8 @@ static const struct file_operations asids_debugfs_fops = {

static int __init asids_debugfs_init(void)
{
struct dentry *asids_dentry;

asids_dentry = debugfs_create_file("asids", S_IRUSR, arch_debugfs_dir,
NULL, &asids_debugfs_fops);
if (!asids_dentry)
return -ENOMEM;

return PTR_ERR_OR_ZERO(asids_dentry);
debugfs_create_file("asids", S_IRUSR, arch_debugfs_dir, NULL,
&asids_debugfs_fops);
return 0;
}
device_initcall(asids_debugfs_init);
20 changes: 4 additions & 16 deletions arch/sh/mm/cache-debugfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -109,22 +109,10 @@ static const struct file_operations cache_debugfs_fops = {

static int __init cache_debugfs_init(void)
{
struct dentry *dcache_dentry, *icache_dentry;

dcache_dentry = debugfs_create_file("dcache", S_IRUSR, arch_debugfs_dir,
(unsigned int *)CACHE_TYPE_DCACHE,
&cache_debugfs_fops);
if (!dcache_dentry)
return -ENOMEM;

icache_dentry = debugfs_create_file("icache", S_IRUSR, arch_debugfs_dir,
(unsigned int *)CACHE_TYPE_ICACHE,
&cache_debugfs_fops);
if (!icache_dentry) {
debugfs_remove(dcache_dentry);
return -ENOMEM;
}

debugfs_create_file("dcache", S_IRUSR, arch_debugfs_dir,
(void *)CACHE_TYPE_DCACHE, &cache_debugfs_fops);
debugfs_create_file("icache", S_IRUSR, arch_debugfs_dir,
(void *)CACHE_TYPE_ICACHE, &cache_debugfs_fops);
return 0;
}
module_init(cache_debugfs_init);
Expand Down
9 changes: 2 additions & 7 deletions arch/sh/mm/pmb.c
Original file line number Diff line number Diff line change
Expand Up @@ -861,13 +861,8 @@ static const struct file_operations pmb_debugfs_fops = {

static int __init pmb_debugfs_init(void)
{
struct dentry *dentry;

dentry = debugfs_create_file("pmb", S_IFREG | S_IRUGO,
arch_debugfs_dir, NULL, &pmb_debugfs_fops);
if (!dentry)
return -ENOMEM;

debugfs_create_file("pmb", S_IFREG | S_IRUGO, arch_debugfs_dir, NULL,
&pmb_debugfs_fops);
return 0;
}
subsys_initcall(pmb_debugfs_init);
Expand Down
20 changes: 4 additions & 16 deletions arch/sh/mm/tlb-debugfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -149,22 +149,10 @@ static const struct file_operations tlb_debugfs_fops = {

static int __init tlb_debugfs_init(void)
{
struct dentry *itlb, *utlb;

itlb = debugfs_create_file("itlb", S_IRUSR, arch_debugfs_dir,
(unsigned int *)TLB_TYPE_ITLB,
&tlb_debugfs_fops);
if (unlikely(!itlb))
return -ENOMEM;

utlb = debugfs_create_file("utlb", S_IRUSR, arch_debugfs_dir,
(unsigned int *)TLB_TYPE_UTLB,
&tlb_debugfs_fops);
if (unlikely(!utlb)) {
debugfs_remove(itlb);
return -ENOMEM;
}

debugfs_create_file("itlb", S_IRUSR, arch_debugfs_dir,
(void *)TLB_TYPE_ITLB, &tlb_debugfs_fops);
debugfs_create_file("utlb", S_IRUSR, arch_debugfs_dir,
(void *)TLB_TYPE_UTLB, &tlb_debugfs_fops);
return 0;
}
module_init(tlb_debugfs_init);
Expand Down

0 comments on commit 03eb2a0

Please sign in to comment.