Skip to content

Commit

Permalink
[SCSI] fcoe: Correct fcoe_transports initialization vs. registration
Browse files Browse the repository at this point in the history
The registration function shouldn't initialize the mutex or
list head. The fcoe SW transport should initialize itself
before registering.

Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
  • Loading branch information
Robert Love authored and James Bottomley committed Mar 10, 2009
1 parent a468f32 commit 03ec862
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
3 changes: 0 additions & 3 deletions drivers/scsi/fcoe/fc_transport_fcoe.c
Original file line number Diff line number Diff line change
Expand Up @@ -258,9 +258,6 @@ int fcoe_transport_register(struct fcoe_transport *t)
list_add_tail(&t->list, &fcoe_transports);
mutex_unlock(&fcoe_transports_lock);

mutex_init(&t->devlock);
INIT_LIST_HEAD(&t->devlist);

printk(KERN_DEBUG "fcoe_transport_register:%s\n", t->name);

return 0;
Expand Down
5 changes: 5 additions & 0 deletions drivers/scsi/fcoe/fcoe_sw.c
Original file line number Diff line number Diff line change
Expand Up @@ -467,10 +467,15 @@ int __init fcoe_sw_init(void)
/* attach to scsi transport */
scsi_transport_fcoe_sw =
fc_attach_transport(&fcoe_sw_transport_function);

if (!scsi_transport_fcoe_sw) {
printk(KERN_ERR "fcoe_sw_init:fc_attach_transport() failed\n");
return -ENODEV;
}

mutex_init(&fcoe_sw_transport.devlock);
INIT_LIST_HEAD(&fcoe_sw_transport.devlist);

/* register sw transport */
fcoe_transport_register(&fcoe_sw_transport);
return 0;
Expand Down

0 comments on commit 03ec862

Please sign in to comment.