Skip to content

Commit

Permalink
HID: sony: remove redundant check for -ve err
Browse files Browse the repository at this point in the history
err is being checked for failure each time it is being updated
so this err check is totally redundant and can be removed

Detected with CoverityScan, CID#1420665 ("Logically dead code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
  • Loading branch information
Colin Ian King authored and Jiri Kosina committed Apr 6, 2017
1 parent a676bdc commit 040fc00
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions drivers/hid/hid-sony.c
Original file line number Diff line number Diff line change
Expand Up @@ -2654,9 +2654,6 @@ static int sony_input_configured(struct hid_device *hdev,
ret = 0;
}

if (ret < 0)
goto err_stop;

if (sc->quirks & SONY_LED_SUPPORT) {
ret = sony_leds_init(sc);
if (ret < 0)
Expand Down

0 comments on commit 040fc00

Please sign in to comment.