Skip to content

Commit

Permalink
tools, bpftool: Fix wrong return value in do_dump()
Browse files Browse the repository at this point in the history
In case of btf_id does not exist, a negative error code -ENOENT
should be returned.

Fixes: c93cc69 ("bpftool: add ability to dump BTF types")
Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Reviewed-by: Tobias Klauser <tklauser@distanz.ch>
Acked-by: Andrii Nakryiko <andriin@fb.com>
Acked-by: John Fastabend <john.fastabend@gmail.com>
Link: https://lore.kernel.org/bpf/20200802111540.5384-1-tianjia.zhang@linux.alibaba.com
  • Loading branch information
Tianjia Zhang authored and Daniel Borkmann committed Aug 3, 2020
1 parent a278f3d commit 041549b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/bpf/bpftool/btf.c
Original file line number Diff line number Diff line change
Expand Up @@ -596,7 +596,7 @@ static int do_dump(int argc, char **argv)
goto done;
}
if (!btf) {
err = ENOENT;
err = -ENOENT;
p_err("can't find btf with ID (%u)", btf_id);
goto done;
}
Expand Down

0 comments on commit 041549b

Please sign in to comment.