Skip to content

Commit

Permalink
trace: fix compiler warning in branch profiler
Browse files Browse the repository at this point in the history
Impact: fix compiler warning

The ftrace_pointers used in the branch profiler are constant values.
They should never change. But the compiler complains when they are
passed into the debugfs_create_file as a data pointer, because the
function discards the qualifier.

This patch typecasts the parameter to debugfs_create_file back to
a void pointer. To remind the callbacks that they are pointing to
a constant value, I also modified the callback local pointers to
be const struct ftrace_pointer * as well.

Signed-off-by: Steven Rostedt <srostedt@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Steven Rostedt authored and Ingo Molnar committed Nov 23, 2008
1 parent 2bcd521 commit 0429149
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions kernel/trace/trace_branch.c
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ struct ftrace_pointer {
static void *
t_next(struct seq_file *m, void *v, loff_t *pos)
{
struct ftrace_pointer *f = m->private;
const struct ftrace_pointer *f = m->private;
struct ftrace_branch_data *p = v;

(*pos)++;
Expand Down Expand Up @@ -224,7 +224,7 @@ static void t_stop(struct seq_file *m, void *p)

static int t_show(struct seq_file *m, void *v)
{
struct ftrace_pointer *fp = m->private;
const struct ftrace_pointer *fp = m->private;
struct ftrace_branch_data *p = v;
const char *f;
long percent;
Expand Down Expand Up @@ -296,7 +296,7 @@ static const struct file_operations tracing_branch_fops = {
extern unsigned long __start_branch_profile[];
extern unsigned long __stop_branch_profile[];

static struct ftrace_pointer ftrace_branch_pos = {
static const struct ftrace_pointer ftrace_branch_pos = {
.start = __start_branch_profile,
.stop = __stop_branch_profile,
.hit = 1,
Expand All @@ -320,15 +320,15 @@ static __init int ftrace_branch_init(void)
d_tracer = tracing_init_dentry();

entry = debugfs_create_file("profile_annotated_branch", 0444, d_tracer,
&ftrace_annotated_branch_pos,
(void *)&ftrace_annotated_branch_pos,
&tracing_branch_fops);
if (!entry)
pr_warning("Could not create debugfs "
"'profile_annotatet_branch' entry\n");

#ifdef CONFIG_PROFILE_ALL_BRANCHES
entry = debugfs_create_file("profile_branch", 0444, d_tracer,
&ftrace_branch_pos,
(void *)&ftrace_branch_pos,
&tracing_branch_fops);
if (!entry)
pr_warning("Could not create debugfs"
Expand Down

0 comments on commit 0429149

Please sign in to comment.