Skip to content

Commit

Permalink
extcon: int3496: process id-pin first so that we start with the right…
Browse files Browse the repository at this point in the history
… status

Some other drivers may be waiting for our extcon to show-up, exiting their
probe methods with -EPROBE_DEFER until we show up.

These drivers will typically get the cable state directly after getting
the extcon, this commit changes the int3496 code to wait for the initial
processing of the id-pin to complete before exiting probe() with 0, which
will cause devices waiting on the defered probe to get reprobed.

This fixes a race where the initial work might still be running while other
drivers were already calling extcon_get_state().

Fixes: 2f556bd ("extcon: int3496: Add Intel INT3496 ACPI ... driver")
Cc: stable@vger.kernel.org
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
  • Loading branch information
Hans de Goede authored and Chanwoo Choi committed Feb 13, 2018
1 parent d82e233 commit 0434352
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/extcon/extcon-intel-int3496.c
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,9 @@ static int int3496_probe(struct platform_device *pdev)
return ret;
}

/* queue initial processing of id-pin */
/* process id-pin so that we start with the right status */
queue_delayed_work(system_wq, &data->work, 0);
flush_delayed_work(&data->work);

platform_set_drvdata(pdev, data);

Expand Down

0 comments on commit 0434352

Please sign in to comment.