Skip to content

Commit

Permalink
thermal: gov_power_allocator: Remove excessive local variables
Browse files Browse the repository at this point in the history
Local variable 'ret' in allocate_power() is only used in the return
statement, so drop it.

Local variable 'trip_max' in allocate_power() is only used for caching
the params->trip_max value which may as well be accessed directly as
needed, so drop it either.

This change is not expected to alter the general functionality.

Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
[ rjw: Subject and changelog edits ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  • Loading branch information
Lukasz Luba authored and Rafael J. Wysocki committed Nov 28, 2023
1 parent 30e1178 commit 0458d53
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions drivers/thermal/gov_power_allocator.c
Original file line number Diff line number Diff line change
Expand Up @@ -379,17 +379,16 @@ static int allocate_power(struct thermal_zone_device *tz, int control_temp)
u32 total_req_power, max_allocatable_power, total_weighted_req_power;
u32 *req_power, *max_power, *granted_power, *extra_actor_power;
struct power_allocator_params *params = tz->governor_data;
const struct thermal_trip *trip_max = params->trip_max;
u32 total_granted_power, power_range;
struct thermal_cooling_device *cdev;
struct thermal_instance *instance;
u32 *weighted_req_power;
int i, weight, ret = 0;
int total_weight = 0;
int num_actors = 0;
int i, weight;

list_for_each_entry(instance, &tz->thermal_instances, tz_node) {
if ((instance->trip == trip_max) &&
if ((instance->trip == params->trip_max) &&
cdev_is_power_actor(instance->cdev)) {
num_actors++;
total_weight += instance->weight;
Expand Down Expand Up @@ -427,7 +426,7 @@ static int allocate_power(struct thermal_zone_device *tz, int control_temp)
list_for_each_entry(instance, &tz->thermal_instances, tz_node) {
cdev = instance->cdev;

if (instance->trip != trip_max)
if (instance->trip != params->trip_max)
continue;

if (!cdev_is_power_actor(cdev))
Expand Down Expand Up @@ -463,7 +462,7 @@ static int allocate_power(struct thermal_zone_device *tz, int control_temp)
total_granted_power = 0;
i = 0;
list_for_each_entry(instance, &tz->thermal_instances, tz_node) {
if (instance->trip != trip_max)
if (instance->trip != params->trip_max)
continue;

if (!cdev_is_power_actor(instance->cdev))
Expand All @@ -484,7 +483,7 @@ static int allocate_power(struct thermal_zone_device *tz, int control_temp)

kfree(req_power);

return ret;
return 0;
}

/**
Expand Down

0 comments on commit 0458d53

Please sign in to comment.