Skip to content

Commit

Permalink
neigh: Kill bogus SMP protected debugging message.
Browse files Browse the repository at this point in the history
Whatever situations make this state legitimate when SMP
also would be legitimate when !SMP and f.e. preemption is
enabled.

This is dubious enough that we should just delete it entirely.  If we
want to add debugging for neigh timer races, better more thorough
mechanisms are needed.

Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
David S. Miller committed Nov 1, 2011
1 parent 563e123 commit 045f7b3
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions net/core/neighbour.c
Original file line number Diff line number Diff line change
Expand Up @@ -872,12 +872,8 @@ static void neigh_timer_handler(unsigned long arg)
now = jiffies;
next = now + HZ;

if (!(state & NUD_IN_TIMER)) {
#ifndef CONFIG_SMP
printk(KERN_WARNING "neigh: timer & !nud_in_timer\n");
#endif
if (!(state & NUD_IN_TIMER))
goto out;
}

if (state & NUD_REACHABLE) {
if (time_before_eq(now,
Expand Down

0 comments on commit 045f7b3

Please sign in to comment.