Skip to content

Commit

Permalink
tools/perf/build: Improve the 'stackprotector' feature test
Browse files Browse the repository at this point in the history
Namhyung Kim noticed that the stackprotector testcase was incomplete:

  > The flag being checked should be -"W"stack-protector instead of
  > -"f"stack-protector.  And the gcc manpage says that -Wstack-protector is
  > only active when -fstack-protector is active.  So the end result should
  > look like
  >
  >         $(BUILD) -Werror -fstack-protector -Wstack-protector

Add -Wstack-protector.

Reported-by: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  • Loading branch information
Ingo Molnar authored and Arnaldo Carvalho de Melo committed Oct 14, 2013
1 parent 01287e2 commit 046fa7a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/perf/config/feature-checks/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ test-stackprotector-all:
$(BUILD) -Werror -fstack-protector-all

test-stackprotector:
$(BUILD) -Werror -fstack-protector
$(BUILD) -Werror -fstack-protector -Wstack-protector

test-fortify-source:
$(BUILD) -O2 -Werror -D_FORTIFY_SOURCE=2
Expand Down

0 comments on commit 046fa7a

Please sign in to comment.