Skip to content

Commit

Permalink
doc-rst: Delete output of failed dot-SVG conversion
Browse files Browse the repository at this point in the history
As we use redirection to create the SVG file, even a failed conversion
will create the file and 'make' will consider it up-to-date if the
build is retried.  We should delete it in case of failure.

Fixes: ec868e4 ("docs-rst: media: build SVG from graphviz files")
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
  • Loading branch information
Ben Hutchings authored and Jonathan Corbet committed Feb 6, 2017
1 parent 85bd902 commit 04b7091
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Documentation/media/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ quiet_cmd_genpdf = GENPDF $2
cmd_genpdf = convert $2 $3

quiet_cmd_gendot = DOT $2
cmd_gendot = dot -Tsvg $2 > $3
cmd_gendot = dot -Tsvg $2 > $3 || { rm -f $3; exit 1; }

%.pdf: %.svg
@$(call cmd,genpdf,$<,$@)
Expand Down

0 comments on commit 04b7091

Please sign in to comment.