Skip to content

Commit

Permalink
powerpc/crash: Remove the test for cpu_online in the IPI callback
Browse files Browse the repository at this point in the history
Our check was extra cautious, we've audited crash_send_ipi
and it sends an IPI only to online CPU's. Removal of this
check should have not functional impact on crash kdump.

Signed-off-by: Balbir Singh <bsingharora@gmail.com>
Reviewed-by: Nicholas Piggin <npiggin@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
  • Loading branch information
Balbir Singh authored and Michael Ellerman committed Jan 16, 2018
1 parent 9625e69 commit 04b9c96
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions arch/powerpc/kernel/crash.c
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,6 @@ static void crash_ipi_callback(struct pt_regs *regs)

int cpu = smp_processor_id();

if (!cpu_online(cpu))
return;

hard_irq_disable();
if (!cpumask_test_cpu(cpu, &cpus_state_saved)) {
crash_save_cpu(regs, cpu);
Expand Down

0 comments on commit 04b9c96

Please sign in to comment.