Skip to content

Commit

Permalink
regulator: bd70528: Fix off-by-one for buck123 .n_voltages setting
Browse files Browse the repository at this point in the history
The valid selectors for bd70528 bucks are 0 ~ 0xf, so the .n_voltages
should be 16 (0x10). Use 0x10 to make it consistent with BD70528_LDO_VOLTS.
Also remove redundant defines for BD70528_BUCK_VOLTS.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Link: https://lore.kernel.org/r/20210523071045.2168904-1-axel.lin@ingics.com
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Axel Lin authored and Mark Brown committed May 24, 2021

Unverified

No user is associated with the committer email.
1 parent 36cb555 commit 0514582
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions include/linux/mfd/rohm-bd70528.h
Original file line number Diff line number Diff line change
@@ -26,9 +26,7 @@ struct bd70528_data {
struct mutex rtc_timer_lock;
};

#define BD70528_BUCK_VOLTS 17
#define BD70528_BUCK_VOLTS 17
#define BD70528_BUCK_VOLTS 17
#define BD70528_BUCK_VOLTS 0x10
#define BD70528_LDO_VOLTS 0x20

#define BD70528_REG_BUCK1_EN 0x0F

0 comments on commit 0514582

Please sign in to comment.