Skip to content

Commit

Permalink
net: 802.1q: make vlan_hwaccel_do_receive() return void
Browse files Browse the repository at this point in the history
vlan_hwaccel_do_receive() always returns 0, so make it return void.

Signed-off-by: Changli Gao <xiaosuo@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Changli Gao authored and David S. Miller committed Aug 23, 2010
1 parent 2436243 commit 0553212
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 7 deletions.
5 changes: 2 additions & 3 deletions include/linux/if_vlan.h
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ extern u16 vlan_dev_vlan_id(const struct net_device *dev);

extern int __vlan_hwaccel_rx(struct sk_buff *skb, struct vlan_group *grp,
u16 vlan_tci, int polling);
extern int vlan_hwaccel_do_receive(struct sk_buff *skb);
extern void vlan_hwaccel_do_receive(struct sk_buff *skb);
extern gro_result_t
vlan_gro_receive(struct napi_struct *napi, struct vlan_group *grp,
unsigned int vlan_tci, struct sk_buff *skb);
Expand Down Expand Up @@ -147,9 +147,8 @@ static inline int __vlan_hwaccel_rx(struct sk_buff *skb, struct vlan_group *grp,
return NET_XMIT_SUCCESS;
}

static inline int vlan_hwaccel_do_receive(struct sk_buff *skb)
static inline void vlan_hwaccel_do_receive(struct sk_buff *skb)
{
return 0;
}

static inline gro_result_t
Expand Down
3 changes: 1 addition & 2 deletions net/8021q/vlan_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ int __vlan_hwaccel_rx(struct sk_buff *skb, struct vlan_group *grp,
}
EXPORT_SYMBOL(__vlan_hwaccel_rx);

int vlan_hwaccel_do_receive(struct sk_buff *skb)
void vlan_hwaccel_do_receive(struct sk_buff *skb)
{
struct net_device *dev = skb->dev;
struct vlan_rx_stats *rx_stats;
Expand Down Expand Up @@ -69,7 +69,6 @@ int vlan_hwaccel_do_receive(struct sk_buff *skb)
break;
}
u64_stats_update_end(&rx_stats->syncp);
return 0;
}

struct net_device *vlan_dev_real_dev(const struct net_device *dev)
Expand Down
4 changes: 2 additions & 2 deletions net/core/dev.c
Original file line number Diff line number Diff line change
Expand Up @@ -2841,8 +2841,8 @@ static int __netif_receive_skb(struct sk_buff *skb)
if (!netdev_tstamp_prequeue)
net_timestamp_check(skb);

if (vlan_tx_tag_present(skb) && vlan_hwaccel_do_receive(skb))
return NET_RX_SUCCESS;
if (vlan_tx_tag_present(skb))
vlan_hwaccel_do_receive(skb);

/* if we've gotten here through NAPI, check netpoll */
if (netpoll_receive_skb(skb))
Expand Down

0 comments on commit 0553212

Please sign in to comment.