Skip to content

Commit

Permalink
dt-bindings: net: Add missing (unevaluated|additional)Properties on c…
Browse files Browse the repository at this point in the history
…hild nodes

In order to ensure only documented properties are present, node schemas
must have unevaluatedProperties or additionalProperties set to false
(typically). Add missing properties/$refs as exposed by this addition.

Signed-off-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20220825192609.1538463-1-robh@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Rob Herring authored and Jakub Kicinski committed Aug 26, 2022
1 parent 880b0dd commit 057062a
Showing 6 changed files with 19 additions and 24 deletions.
Original file line number Diff line number Diff line change
@@ -37,6 +37,7 @@ properties:
patternProperties:
"^ethernet-port@[0-9]+$":
type: object
unevaluatedProperties: false
description: contains the resources for ethernet port
allOf:
- $ref: ethernet-controller.yaml#
34 changes: 10 additions & 24 deletions Documentation/devicetree/bindings/net/microchip,sparx5-switch.yaml
Original file line number Diff line number Diff line change
@@ -74,16 +74,20 @@ properties:

ethernet-ports:
type: object
additionalProperties: false

properties:
'#address-cells':
const: 1
'#size-cells':
const: 0

patternProperties:
"^port@[0-9a-f]+$":
type: object
$ref: /schemas/net/ethernet-controller.yaml#
unevaluatedProperties: false

properties:
'#address-cells':
const: 1
'#size-cells':
const: 0

reg:
description: Switch port number

@@ -93,29 +97,11 @@ properties:
phandle of a Ethernet SerDes PHY. This defines which SerDes
instance will handle the Ethernet traffic.

phy-mode:
description:
This specifies the interface used by the Ethernet SerDes towards
the PHY or SFP.

microchip,bandwidth:
description: Specifies bandwidth in Mbit/s allocated to the port.
$ref: "/schemas/types.yaml#/definitions/uint32"
maximum: 25000

phy-handle:
description:
phandle of a Ethernet PHY. This is optional and if provided it
points to the cuPHY used by the Ethernet SerDes.

sfp:
description:
phandle of an SFP. This is optional and used when not specifying
a cuPHY. It points to the SFP node that describes the SFP used by
the Ethernet SerDes.

managed: true

microchip,sd-sgpio:
description:
Index of the ports Signal Detect SGPIO in the set of 384 SGPIOs
Original file line number Diff line number Diff line change
@@ -32,6 +32,7 @@ properties:

ethernet-ports:
type: object
additionalProperties: false
description: Ethernet ports to PHY

properties:
@@ -44,6 +45,7 @@ properties:
patternProperties:
"^port@[0-1]$":
type: object
additionalProperties: false
description: Port to PHY

properties:
4 changes: 4 additions & 0 deletions Documentation/devicetree/bindings/net/ti,cpsw-switch.yaml
Original file line number Diff line number Diff line change
@@ -77,6 +77,8 @@ properties:

ethernet-ports:
type: object
additionalProperties: false

properties:
'#address-cells':
const: 1
@@ -89,6 +91,7 @@ properties:
description: CPSW external ports

$ref: ethernet-controller.yaml#
unevaluatedProperties: false

properties:
reg:
@@ -117,6 +120,7 @@ properties:

cpts:
type: object
unevaluatedProperties: false
description:
The Common Platform Time Sync (CPTS) module

Original file line number Diff line number Diff line change
@@ -116,6 +116,7 @@ properties:
description: CPSWxG NUSS external ports

$ref: ethernet-controller.yaml#
unevaluatedProperties: false

properties:
reg:
Original file line number Diff line number Diff line change
@@ -95,6 +95,7 @@ properties:

refclk-mux:
type: object
additionalProperties: false
description: CPTS reference clock multiplexer clock
properties:
'#clock-cells':

0 comments on commit 057062a

Please sign in to comment.