Skip to content

Commit

Permalink
mei: vsc: Call wake_up() in the threaded IRQ handler
Browse files Browse the repository at this point in the history
The hard IRQ handler vsc_tp_irq() is called with a raw spinlock taken.
wake_up() acquires a spinlock, a sleeping lock on PREEMPT_RT. This leads
to sleeping in atomic context.

Move the wake_up() call to the threaded IRQ handler vsc_tp_thread_isr()
where it can be safely called.

Fixes: 566f5ca ("mei: Add transport driver for IVSC device")
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Tested-and-Reviewed-by: Wentong Wu <wentong.wu@intel.com>
Link: https://lore.kernel.org/r/20240219195807.517742-2-sakari.ailus@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Sakari Ailus authored and Greg Kroah-Hartman committed Mar 5, 2024
1 parent e37db17 commit 058a38a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/misc/mei/vsc-tp.c
Original file line number Diff line number Diff line change
Expand Up @@ -416,15 +416,15 @@ static irqreturn_t vsc_tp_isr(int irq, void *data)

atomic_inc(&tp->assert_cnt);

wake_up(&tp->xfer_wait);

return IRQ_WAKE_THREAD;
}

static irqreturn_t vsc_tp_thread_isr(int irq, void *data)
{
struct vsc_tp *tp = data;

wake_up(&tp->xfer_wait);

if (tp->event_notify)
tp->event_notify(tp->event_notify_context);

Expand Down

0 comments on commit 058a38a

Please sign in to comment.