Skip to content

Commit

Permalink
perf symbols: Record whether a symbol is an alias for an IFUNC symbol
Browse files Browse the repository at this point in the history
To assist with synthesizing plt symbols for IFUNCs, record whether a
symbol is an alias of an IFUNC symbol.

Reviewed-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Link: https://lore.kernel.org/r/20230131131625.6964-5-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  • Loading branch information
Adrian Hunter authored and Arnaldo Carvalho de Melo committed Feb 2, 2023
1 parent 7825028 commit 0596349
Showing 2 changed files with 6 additions and 0 deletions.
4 changes: 4 additions & 0 deletions tools/perf/util/symbol.c
Original file line number Diff line number Diff line change
@@ -201,10 +201,14 @@ void symbols__fixup_duplicate(struct rb_root_cached *symbols)
continue;

if (choose_best_symbol(curr, next) == SYMBOL_A) {
if (next->type == STT_GNU_IFUNC)
curr->ifunc_alias = true;
rb_erase_cached(&next->rb_node, symbols);
symbol__delete(next);
goto again;
} else {
if (curr->type == STT_GNU_IFUNC)
next->ifunc_alias = true;
nd = rb_next(&curr->rb_node);
rb_erase_cached(&curr->rb_node, symbols);
symbol__delete(curr);
2 changes: 2 additions & 0 deletions tools/perf/util/symbol.h
Original file line number Diff line number Diff line change
@@ -64,6 +64,8 @@ struct symbol {
u8 inlined:1;
/** Has symbol__annotate2 been performed. */
u8 annotate2:1;
/** Symbol is an alias of an STT_GNU_IFUNC */
u8 ifunc_alias:1;
/** Architecture specific. Unused except on PPC where it holds st_other. */
u8 arch_sym;
/** The name of length namelen associated with the symbol. */

0 comments on commit 0596349

Please sign in to comment.