Skip to content

Commit

Permalink
octeontx2-af: Use the bitmap API to allocate bitmaps
Browse files Browse the repository at this point in the history
Use devm_bitmap_zalloc() instead of hand-writing it.

This also makes the comment "Allocate bitmap for 32 entry mcam" more
explicit because now 32 is really used in the allocation function, instead
of an obscure 'sizeof(long)'.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/24177a9ee7043259448b735263d9cfd6a70e89a4.1669378798.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Christophe JAILLET authored and Jakub Kicinski committed Dec 1, 2022
1 parent b6a0eca commit 05a7b52
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c
Original file line number Diff line number Diff line change
Expand Up @@ -1898,15 +1898,15 @@ int rvu_npc_exact_init(struct rvu *rvu)
table_size = table->mem_table.depth * table->mem_table.ways;

/* Allocate bitmap for 4way 2K table */
table->mem_table.bmap = devm_kcalloc(rvu->dev, BITS_TO_LONGS(table_size),
sizeof(long), GFP_KERNEL);
table->mem_table.bmap = devm_bitmap_zalloc(rvu->dev, table_size,
GFP_KERNEL);
if (!table->mem_table.bmap)
return -ENOMEM;

dev_dbg(rvu->dev, "%s: Allocated bitmap for 4way 2K entry table\n", __func__);

/* Allocate bitmap for 32 entry mcam */
table->cam_table.bmap = devm_kcalloc(rvu->dev, 1, sizeof(long), GFP_KERNEL);
table->cam_table.bmap = devm_bitmap_zalloc(rvu->dev, 32, GFP_KERNEL);

if (!table->cam_table.bmap)
return -ENOMEM;
Expand Down

0 comments on commit 05a7b52

Please sign in to comment.