Skip to content

Commit

Permalink
ARM: dts: exynos: Use 'hpd-gpios' instead of 'hpd-gpio'
Browse files Browse the repository at this point in the history 
This patch enables getting a HPD GPIO descriptor quicker.
The exynos-hdmi driver uses "hpd" for HDMI hot plug detection.

	static int hdmi_resources_init(struct hdmi_context *hdata)
	{
		...
		hdata->hpd_gpio = devm_gpiod_get(dev, "hpd", GPIOD_IN);
		...
	}

This calls 'of_find_gpio()' and it generates the GPIO consumer ID by referring
GPIO suffix. So 'hpd-gpios' is preferred on getting a GPIO descriptor.

However, if the device tree uses 'hpd-gpio', then the exynos-hdmi driver
always retries to get a GPIO descriptor because the first GPIO suffix is not
'gpio' but 'gpios'. So you always see the debug message below.

	of_get_named_gpiod_flags: can't parse 'hpd-gpios' property of node '/soc/hdmi@14530000[0]'

Use the preferred property, 'hpd-gpios' instead of 'hpd-gpio'.

Acked-by: Rob Herring <robh@kernel.org>
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
Cc: devicetree@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Milo Kim <woogyom.kim@gmail.com>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
  • Loading branch information
Milo Kim authored and Krzysztof Kozlowski committed Aug 24, 2016
1 parent 5a5232d commit 05b01dd
Show file tree
Hide file tree
Showing 11 changed files with 12 additions and 12 deletions.
4 changes: 2 additions & 2 deletions Documentation/devicetree/bindings/display/exynos/exynos_hdmi.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Required properties:
- reg: physical base address of the hdmi and length of memory mapped
region.
- interrupts: interrupt number to the cpu.
- hpd-gpio: following information about the hotplug gpio pin.
- hpd-gpios: following information about the hotplug gpio pin.
a) phandle of the gpio controller node.
b) pin number within the gpio controller.
c) optional flags and pull up/down.
Expand Down Expand Up @@ -56,7 +56,7 @@ Example:
compatible = "samsung,exynos4212-hdmi";
reg = <0x14530000 0x100000>;
interrupts = <0 95 0>;
hpd-gpio = <&gpx3 7 1>;
hpd-gpios = <&gpx3 7 1>;
ddc = <&hdmi_ddc_node>;
phy = <&hdmi_phy_node>;
samsung,syscon-phandle = <&pmu_system_controller>;
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/boot/dts/exynos4210-universal_c210.dts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@
};

&hdmi {
hpd-gpio = <&gpx3 7 GPIO_ACTIVE_HIGH>;
hpd-gpios = <&gpx3 7 GPIO_ACTIVE_HIGH>;
pinctrl-names = "default";
pinctrl-0 = <&hdmi_hpd>;
hdmi-en-supply = <&hdmi_en>;
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/boot/dts/exynos4412-odroid-common.dtsi
View file
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@
};

&hdmi {
hpd-gpio = <&gpx3 7 GPIO_ACTIVE_HIGH>;
hpd-gpios = <&gpx3 7 GPIO_ACTIVE_HIGH>;
pinctrl-names = "default";
pinctrl-0 = <&hdmi_hpd>;
vdd-supply = <&ldo8_reg>;
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/boot/dts/exynos5250-arndale.dts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@
};

&hdmi {
hpd-gpio = <&gpx3 7 GPIO_ACTIVE_LOW>;
hpd-gpios = <&gpx3 7 GPIO_ACTIVE_LOW>;
vdd_osc-supply = <&ldo10_reg>;
vdd_pll-supply = <&ldo8_reg>;
vdd-supply = <&ldo8_reg>;
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/boot/dts/exynos5250-smdk5250.dts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@
};

&hdmi {
hpd-gpio = <&gpx3 7 GPIO_ACTIVE_HIGH>;
hpd-gpios = <&gpx3 7 GPIO_ACTIVE_HIGH>;
};

&i2c_0 {
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/boot/dts/exynos5250-snow-common.dtsi
View file
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@
};

&hdmi {
hpd-gpio = <&gpx3 7 GPIO_ACTIVE_HIGH>;
hpd-gpios = <&gpx3 7 GPIO_ACTIVE_HIGH>;
pinctrl-names = "default";
pinctrl-0 = <&hdmi_hpd_irq>;
phy = <&hdmiphy>;
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/boot/dts/exynos5250-spring.dts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
};

&hdmi {
hpd-gpio = <&gpx3 7 GPIO_ACTIVE_HIGH>;
hpd-gpios = <&gpx3 7 GPIO_ACTIVE_HIGH>;
pinctrl-names = "default";
pinctrl-0 = <&hdmi_hpd_irq>;
phy = <&hdmiphy>;
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/boot/dts/exynos5420-peach-pit.dts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@

&hdmi {
status = "okay";
hpd-gpio = <&gpx3 7 GPIO_ACTIVE_HIGH>;
hpd-gpios = <&gpx3 7 GPIO_ACTIVE_HIGH>;
pinctrl-names = "default";
pinctrl-0 = <&hdmi_hpd_irq>;
ddc = <&i2c_2>;
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/boot/dts/exynos5420-smdk5420.dts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@

&hdmi {
status = "okay";
hpd-gpio = <&gpx3 7 GPIO_ACTIVE_HIGH>;
hpd-gpios = <&gpx3 7 GPIO_ACTIVE_HIGH>;
pinctrl-names = "default";
pinctrl-0 = <&hdmi_hpd_irq>;
};
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
View file
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@

&hdmi {
status = "okay";
hpd-gpio = <&gpx3 7 GPIO_ACTIVE_HIGH>;
hpd-gpios = <&gpx3 7 GPIO_ACTIVE_HIGH>;
pinctrl-names = "default";
pinctrl-0 = <&hdmi_hpd_irq>;

Expand Down
2 changes: 1 addition & 1 deletion arch/arm/boot/dts/exynos5800-peach-pi.dts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@

&hdmi {
status = "okay";
hpd-gpio = <&gpx3 7 GPIO_ACTIVE_HIGH>;
hpd-gpios = <&gpx3 7 GPIO_ACTIVE_HIGH>;
pinctrl-names = "default";
pinctrl-0 = <&hdmi_hpd_irq>;
ddc = <&i2c_2>;
Expand Down

0 comments on commit 05b01dd

Please sign in to comment.