Skip to content

Commit

Permalink
block: add plug while submitting IO
Browse files Browse the repository at this point in the history
So that if caller didn't use plug, for example, __blkdev_direct_IO_simple()
and __blkdev_direct_IO_async(), block layer can still benefit from caching
nsec time in the plug.

Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Link: https://lore.kernel.org/r/20240509123825.3225207-1-yukuai1@huaweicloud.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
  • Loading branch information
Yu Kuai authored and Jens Axboe committed May 9, 2024
1 parent 3a86156 commit 060406c
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions block/blk-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -646,11 +646,13 @@ static void __submit_bio(struct bio *bio)
static void __submit_bio_noacct(struct bio *bio)
{
struct bio_list bio_list_on_stack[2];
struct blk_plug plug;

BUG_ON(bio->bi_next);

bio_list_init(&bio_list_on_stack[0]);
current->bio_list = bio_list_on_stack;
blk_start_plug(&plug);

do {
struct request_queue *q = bdev_get_queue(bio->bi_bdev);
Expand Down Expand Up @@ -684,19 +686,23 @@ static void __submit_bio_noacct(struct bio *bio)
bio_list_merge(&bio_list_on_stack[0], &bio_list_on_stack[1]);
} while ((bio = bio_list_pop(&bio_list_on_stack[0])));

blk_finish_plug(&plug);
current->bio_list = NULL;
}

static void __submit_bio_noacct_mq(struct bio *bio)
{
struct bio_list bio_list[2] = { };
struct blk_plug plug;

current->bio_list = bio_list;
blk_start_plug(&plug);

do {
__submit_bio(bio);
} while ((bio = bio_list_pop(&bio_list[0])));

blk_finish_plug(&plug);
current->bio_list = NULL;
}

Expand Down

0 comments on commit 060406c

Please sign in to comment.