Skip to content

Commit

Permalink
fsi: Add fsi-master class
Browse files Browse the repository at this point in the history
This change adds a device class for FSI masters, allowing access under
/sys/class/fsi-master/, and easier udev rules.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Signed-off-by: Joel Stanley <joel@jms.id.au>
  • Loading branch information
Jeremy Kerr authored and Joel Stanley committed Nov 1, 2019
1 parent 54ecb8f commit 0604d53
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions drivers/fsi/fsi-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -1241,6 +1241,10 @@ static ssize_t master_break_store(struct device *dev,

static DEVICE_ATTR(break, 0200, NULL, master_break_store);

struct class fsi_master_class = {
.name = "fsi-master",
};

int fsi_master_register(struct fsi_master *master)
{
int rc;
Expand All @@ -1249,6 +1253,7 @@ int fsi_master_register(struct fsi_master *master)
mutex_init(&master->scan_lock);
master->idx = ida_simple_get(&master_ida, 0, INT_MAX, GFP_KERNEL);
dev_set_name(&master->dev, "fsi%d", master->idx);
master->dev.class = &fsi_master_class;

rc = device_register(&master->dev);
if (rc) {
Expand Down Expand Up @@ -1350,8 +1355,15 @@ static int __init fsi_init(void)
rc = bus_register(&fsi_bus_type);
if (rc)
goto fail_bus;

rc = class_register(&fsi_master_class);
if (rc)
goto fail_class;

return 0;

fail_class:
bus_unregister(&fsi_bus_type);
fail_bus:
unregister_chrdev_region(fsi_base_dev, FSI_CHAR_MAX_DEVICES);
return rc;
Expand All @@ -1360,6 +1372,7 @@ postcore_initcall(fsi_init);

static void fsi_exit(void)
{
class_unregister(&fsi_master_class);
bus_unregister(&fsi_bus_type);
unregister_chrdev_region(fsi_base_dev, FSI_CHAR_MAX_DEVICES);
ida_destroy(&fsi_minor_ida);
Expand Down

0 comments on commit 0604d53

Please sign in to comment.